[delight] Improve shared-workflow validation errors in schema_validation.go

[github-actions[bot]]

User Experience Analysis Report (limited scope)

Tool permissions blocked reading most pre-sampled files, so only pkg/parser/schema_validation.go was reviewed. Docs, CLI and workflow messages were not reviewed.

Overall quality: Needs Minor Work

Quality highlights

• Errors name the offending field and the reason.

Task: Make shared-workflow field errors deterministic and actionable

File to modify: pkg/parser/schema_validation.go (only)

Current experience

• validateSharedWorkflowFields (about lines 58-86) collects forbidden fields by iterating a map, so the multi-field error lists them in random order between runs.
• Line 140 says "field on cannot be used in shared workflows (only import-safe on fields are allowed)" without listing the allowed fields, although sharedWorkflowAllowedOnFieldList exists.
• The concurrency and features errors give no fix hint.

Proposal

• Sort forbiddenFound before formatting.
• Include the allowed on fields in the message, built from sharedWorkflowAllowedOnFieldList.
• Add a hint such as "Move this field to the main workflow."

Success criteria

• Only pkg/parser/schema_validation.go changes (tests asserting message text may need updating).
• Output is stable across runs.
• Every error says how to fix the problem.

📊 User experience analysis by Delight · copilot · auto · 15.2 AIC · ⌖ 0.699 AIC · ⊞ 12.1K · ◷

• expires on Oct 11, 2026, 6:55 AM UTC-08:00