[terminal-stylist] Terminal output consistency audit for Go CLI code

[github-actions[bot]]

Overview

Analyzed every non-test Go source file in the repository, with pkg/ as the primary review area. The scan covered 1,741 .go files excluding _test.go: 1,721 under pkg/ and 20 elsewhere. Serena/gopls semantic lookup and diagnostics completed successfully; the sampled console and theme files had no language-server diagnostics.

The overall foundation is strong: gh-aw has a substantial pkg/console abstraction, adaptive styling, destination-aware TTY checks, color-profile degradation, a shared Huh theme, accessible-mode support, and clean non-TTY fallbacks. The main consistency gap is not missing infrastructure—it is a set of older or specialized renderers that still write presentation-heavy text directly with fmt.Fprint*.

Key metrics

Pattern	Matches	Files	Notes
console.*	2,259	293	Broad use of shared formatting/rendering
Lipgloss	113	9	Concentrated in shared styles, console rendering, TUI/calendar/timeline code
Huh	120	18	All direct form construction is centralized through pkg/console/prompt_form.go
Raw ANSI literals	17	4	Isolated to ANSI parsing/cleanup and terminal cursor control
Bare fmt.Print*	48	9	Mostly tooling, linter fixtures, and comments—not production CLI presentation
Direct stdout/stderr fmt.Fprint* lines in pkg/	2,712	285	1,868 are console-formatted on the same line; 844 are raw, multiline-formatted, structured payloads, or indirect render output

The final count is a syntactic inventory, not 844 defects. JSON, Markdown, YAML, generated content, command output passthrough, and writer-based renderers should remain plain.

What is working well

• TTY and color handling: pkg/console/console.go checks the actual output destination and degrades Lipgloss output through pkg/colorwriter instead of assuming true color. It also exposes distinct stdout/stderr formatters.
• Adaptive palette: pkg/styles/theme.go centralizes light/dark colors; pkg/styles/huh_theme.go maps the same palette with lipgloss.LightDark, avoiding a separate form color system.
• Huh accessibility: pkg/console/prompt_form.go applies WithAccessible(IsAccessibleMode()) and the shared theme to every Huh form. A repository scan found the only huh.NewForm call there, so callers do not silently bypass accessibility.
• Graceful interactivity: pkg/console/confirm.go, pkg/console/list.go, and pkg/cli/interactive.go distinguish stdin from stderr TTY availability and provide text fallbacks or clear errors. Password fields in pkg/cli/engine_secrets.go use huh.EchoModePassword.
• Reusable layouts: pkg/console/console.go uses lipgloss/table, bounded rendering, shared borders, and non-TTY rendering rather than hand-built ANSI tables. pkg/console/render.go provides structured rendering for tagged Go values.
• ANSI containment: pkg/console/terminal.go and pkg/console/prompt_form.go guard cursor-control sequences with TTY/accessibility conditions; pkg/stringutil/ansi.go and pkg/cli/mcp_compile_diagnostics.go handle removal/detection rather than user-facing decoration.
• Good focused implementations: pkg/cli/compile_schedule_calendar.go checks stderr TTY and degrades styled cells; pkg/cli/work_command_tui_view.go appropriately uses Lipgloss layout inside a Bubble Tea TUI.

Priority findings

1. Standardize the MCP inspector terminal view

pkg/cli/mcp_inspect_mcp.go is the clearest migration target. displayDetailedToolInfo mixes console.PrintSectionHeader with raw emoji, literal Markdown emphasis such as **Name:**, fenced JSON, and unformatted Error displaying ... lines on stderr. In an interactive terminal the Markdown markers are visible rather than rendered, and the error lines bypass the shared severity style.

Recommended direction:

• Render metadata and annotations with console.RenderStruct or a two-column console.RenderTable.
• Use console.PrintSuccessMessage, PrintWarningMessage, and PrintErrorMessage for allowance and schema-rendering status.
• Show schema as indented plain text under a section header in terminal mode; reserve fenced Markdown for an explicit machine/Markdown output mode.
• Keep tool names and descriptions uncolored where color would obscure copy/paste behavior.

2. Remove mixed raw/styled status output in watch mode

pkg/cli/compile_watch.go combines destination-aware console formatters with raw strings and emoji (🔨, 🛑). Similar states therefore have different prefixes, color behavior, and accessibility characteristics.

Use the existing progress/info/success formatter family for initial compilation, watch-ready, and shutdown states. This is a small migration with high visibility because watch mode is long-running and repeatedly emits status.

3. Route one-off renderers through a destination-aware helper

pkg/cli/gateway_logs_timeline_render.go correctly disables Lipgloss when stdout is not a TTY, but its local streamColor calls Style.Render directly when it is a TTY. Unlike pkg/console, this path does not visibly apply the repository color-profile degradation layer. Expose a small public stdout/stderr style-render helper from pkg/console, or render the timeline through a console-owned API, so TTY detection, NO_COLOR/profile behavior, and future accessibility policy remain centralized.

The same rule should guide future one-off Lipgloss usage: Bubble Tea views may render directly; ordinary command output should use the console layer.

4. Reduce duplicated interactive option models

pkg/cli/interactive.go has well-structured Huh groups, descriptions, a validated text field, and a non-TTY path. However, trigger, engine, tool, and network choices are duplicated between Huh and text fallback construction. The engine list is also separately represented by the engine catalog elsewhere.

Define shared option descriptors and adapt them to []huh.Option[T] or numbered text choices. This prevents interactive and accessible/non-TTY experiences from drifting as engines or tools are added.

5. Make long forms responsive to terminal height

The main workflow form uses fixed field heights (8 and 10), while PromptForm reserves a fixed 40 rows for cursor restoration. The cleanup behavior is thoughtful, but small terminals can still present a cramped form. Clamp field/form heights to terminal dimensions when available, and let accessible mode remain linear and unbounded. Preserve Huh keyboard defaults rather than implementing custom navigation.

Pattern examples

Preferred: pkg/console/console.go returns plain text for non-TTY destinations and otherwise runs colorwriter.Degrade(style.Render(text), environ). Call sites then select a formatter that matches both severity and destination.

Preferred: pkg/console/prompt_form.go wraps huh.NewForm(...).WithTheme(styles.HuhTheme).WithAccessible(accessible), ensuring every form receives consistent theming and screen-reader behavior.

Needs improvement: pkg/cli/mcp_inspect_mcp.go emits 📋 **Name:** ... directly to stderr and prints schema failures as raw Error displaying ...; use a console table/section and error formatter.

Needs improvement: pkg/cli/compile_watch.go emits some states through FormatProgressMessageStderr and adjacent states as raw emoji strings; use one semantic status vocabulary.

Suggested implementation order

1. Refactor displayDetailedToolInfo in pkg/cli/mcp_inspect_mcp.go to shared console sections/tables and semantic errors.
2. Normalize pkg/cli/compile_watch.go status lines.
3. Add a destination-aware public style helper for specialized renderers, then migrate the gateway timeline.
4. Consolidate interactive option descriptors in pkg/cli/interactive.go.
5. Add narrow-terminal coverage for the multi-page Huh workflow form.

For regression coverage, verify stderr-vs-stdout TTY behavior, non-TTY output with no escape sequences, NO_COLOR/limited color profiles, accessible mode, cancellation (huh.ErrUserAborted), and small terminal dimensions.

References:

• §39572280642

Generated by 💄 Terminal Stylist · pi · gpt56 · 86.9 AIC · ⌖ 11.8 AIC · ⊞ 8.1K · ◷

• expires on Oct 22, 2026, 12:59 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-10-22T08:59:01.048Z.

Closed by Workflow