Repository navigation
[Schema Consistency] 🔍 Schema Consistency Check - 2026-10-22 #71050
Closed
Replies: 1 comment
|
This discussion has been marked as outdated by Schema Consistency Checker. A newer discussion is available at Discussion #71359. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Overview
Found 3 confirmed inconsistencies across schema, compiler, and documentation. Reviewed workflow usage using the precomputed root-field comparison and a targeted release-workflow check. No source files changed.
Key Issues
allowed-repos: currentalias. The reference explicitly promises normalization, but the schema rejects this string. A migration codemod already rewrites it to${{ github.repository }}. Update the prose and example to the accepted expression and explain migration withgh aw fix.safe-outputs.close-issue.allow-bodyis implemented and documented but missing from the schema. The documentation promises comment suppression, the compiler configuration carries the boolean, and handler serialization emits it; schema validation rejects it as an additional property. Add the boolean property and a regression check through normal compilation.safe-outputs.update-release.github-tokenis parsed and documented but missing from the schema. The release example supplies a per-output token; the shared update parser reads it, but the release schema rejects it as an additional property. Add the appropriate existing token-schema reference and validate the published example through compilation.Evidence and minimal reproductions
1. Removed repository alias
docs/src/content/docs/reference/cross-repository.md:71describescurrent; the example begins at line 82.pkg/parser/schemas/main_workflow_schema.json:5082limits scalar allowed-repos toall,public, or${{ github.repository }}.pkg/cli/codemod_allowed_repos_current.go:5defines the migration and rewrites the alias.{"tools":{"github":{"allowed-repos":"current"}}}.2. Missing close-issue property
docs/src/content/docs/reference/safe-outputs.md:399includesallow-body: falseand explains suppression immediately below.pkg/parser/schemas/main_workflow_schema.json:7865omits allow-body and sets additionalProperties to false.pkg/workflow/close_entity_helpers.go:87declaresAllowBody;pkg/workflow/safe_outputs_handler_registry_issues.go:50serializes it as allow_body.{"safe-outputs":{"close-issue":{"allow-body":false}}}.3. Missing release token property
docs/src/content/docs/reference/safe-outputs.md:1156supplies a custom token in the release configuration.pkg/parser/schemas/main_workflow_schema.json:12557omits github-token and rejects additional properties.pkg/workflow/update_release.go:15calls the shared update parser;pkg/workflow/update_entity_helpers.go:167parses common base fields;pkg/workflow/safe_outputs_config_base.go:38reads github-token.{"safe-outputs":{"update-release":{"github-token":"${{ secrets.CUSTOM_TOKEN }}"}}}. This is a literal documentation expression; no secret was accessed.Ruled-out leads and workflow scope
The precomputed gaps for docker-image-pull-policy and work-queue-policy are false positives from tagged-field enumeration:
pkg/workflow/docker.go:294andpkg/workflow/work_queue_policy.go:184consume RawFrontmatter. Neither is counted as a missing implementation.The supplied diff reports no workflow root keys absent from the schema. The checkout contains 346 root workflow Markdown files and 147 shared Markdown files. These counts are scope context, not a claim that every file was compiled or every nested configuration validated.
.github/workflows/release.md:36enables update-release without the rejected token option. No confirmed workflow violation was established. Shared components were not treated as complete workflows.AWF comparison limitation
The precomputed AWF comparison has degraded=true because canonical-source retrieval failed. Non-authoritative warning only: canonical AWF config-source consistency could not be assessed. No AWF drift finding, failed required check, corrective PR, or drift issue is proposed from this incomplete comparison.
Recommendations and Next Steps
Parser updates required: none established; preserve the existing consumers and align schema acceptance with them.
Strategy performance: 3 confirmed findings; high effectiveness; reuse recommended. Updated strategy-2 in the persistent strategy database with this run and findings.
References: §39728537998
All reactions