[Code Quality] Eliminate redundant zero-capacity slice allocations

[github-actions]

Description

Found 10 instances of explicit make([]T, 0) allocations across the codebase. This pattern is redundant and less idiomatic than zero-value slices in Go.

Current Pattern

envVarNames := make([]string, 0)  // Redundant allocation
for _, name := range vars {
    envVarNames = append(envVarNames, name)
}

Proposed Pattern

var envVarNames []string  // Cleaner, idiomatic Go
for _, name := range vars {
    envVarNames = append(envVarNames, name)
}

Locations to Fix

Production Code (8 instances)

• pkg/workflow/mcp_setup_generator.go:607
• pkg/workflow/jobs.go:48, 432
• pkg/workflow/action_cache.go:241, 242, 279
• pkg/workflow/compiler_safe_outputs_job.go:372
• pkg/workflow/step_order_validation.go:42

Test Code (2 instances)

• Test files (acceptable but can be improved)

Success Criteria

• All 10 instances of make([]T, 0) replaced with zero-value declarations
• All existing tests pass
• Verify with go vet (no warnings)
• Review nil slice behavior matches expectations
• Run golangci-lint to confirm no regressions

Impact

• Severity: Low - Minor code quality improvement
• Effort: Low - Estimated 30 minutes
• Risk: Minimal - Zero-value slices work identically with append
• Benefit: More idiomatic Go code, slightly reduced memory allocations

Why This Matters

1. Idiomatic Go: Zero-value slices are the preferred Go pattern
2. Clarity: More explicit about intentional zero initialization
3. Minor optimization: Eliminates unnecessary allocation syscall
4. Consistency: Aligns with Go best practices

Validation Steps

# Find remaining instances
grep -r "make(\[\].*,\s*0)" pkg/

# Run tests
make test-unit

# Verify with go vet
go vet ./...

# Check with linter
make lint

Source

Extracted from Sergo Report: Memory Allocation & Documentation Quality - 2026-01-27

Priority

Low-Medium - Easy improvement, good for first-time contributors

AI generated by Discussion Task Miner - Code Quality Improvement Agent

• expires on Feb 11, 2026, 9:11 AM UTC

[github-actions]

🍪 Issue Monster has assigned this to Copilot!

I've identified this issue as a good candidate for automated resolution and assigned it to the Copilot agent.

The Copilot agent will analyze the issue and create a pull request with the fix.

Om nom nom! 🍪

AI generated by Issue Monster