-
Notifications
You must be signed in to change notification settings - Fork 316
Closed as not planned
Closed as not planned
Copy link
Labels
Description
Contribution Check Report
| Field | Value |
|---|---|
| PR | #22464 |
| Title | [WIP] Fix regression in CompileMemoryUsage performance |
| Author | @Copilot (copilot-swe-agent) |
| Verdict | π’ Aligned |
| Quality | lgtm |
| Existing Labels | (none) |
Checklist Results
| Check | Result | Notes |
|---|---|---|
| On-topic | β yes | Performance regression fix in the workflow compiler β directly relevant to project quality |
| Follows process | β yes | Authored by Copilot coding agent, assigned to core team member pelikhan β exactly the workflow CONTRIBUTING.md prescribes |
| Focused | β yes | All 3 files address the same root cause: YAML library swap (goccy/go-yaml β go.yaml.in/yaml/v3) + benchmark warm-up to exclude one-time cache costs |
| New dependencies | β no | go.yaml.in/yaml/v3 is already a direct dependency in go.mod (v3.0.4); goccy/go-yaml remains in use across the wider codebase |
| Has tests | β yes | compiler_performance_benchmark_test.go updated with warm-up + b.ResetTimer() across all 6 benchmark functions |
| Has description | β yes | PR body contains a fully-checked task list with benchmark numbers (5.6 ms achieved vs 13.4 ms regressed, 7.4 ms historical target) |
| Diff size | 29 lines | 27 additions, 2 deletions across 3 files |
Summary
This is a clean, well-scoped performance fix authored by the Copilot coding agent following the project's prescribed agentic development process. The two changes are tightly coupled β replacing the slower goccy/go-yaml YAML parser with the already-present go.yaml.in/yaml/v3 for schema validation paths, and correctly excluding one-time schema compilation overhead from all benchmark measurements with b.ResetTimer(). The PR body is thorough, all checklist items are marked complete, and tests/lint are confirmed passing. The only marker holding it back from merge is the [WIP] draft status, which the core team reviewer can clear once they're satisfied.
Generated by Contribution Check Β· β·
- expires on Mar 24, 2026, 5:19 PM UTC
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Fields
Give feedbackNo fields configured for issues without a type.