Skip to content

[step-names] Align "Configure Safe Job Environment Variables" with "Safe Outputs" terminology #27415

@github-actions

Description

@github-actions

Step Name Alignment Issue

Found in compiler source: pkg/workflow/safe_jobs.go:244

Affects compiled workflows: daily-choice-test.lock.yml, mcp-inspector.lock.yml, notion-issue-summary.lock.yml, smoke-copilot-arm.lock.yml, smoke-copilot.lock.yml

Summary

One compiler-generated step name uses the term "Safe Job" while all other related step names consistently use "Safe Outputs". This creates a terminology mismatch against both the project glossary and the surrounding step names.

Issue Identified

[High Priority] Terminology Mismatch: "Safe Job" → "Safe Outputs"

Current step name:

  • pkg/workflow/safe_jobs.go:244: "Configure Safe Job Environment Variables"

Inconsistency with neighbouring steps (all using "Safe Outputs"):

  • "Configure Safe Outputs Custom Scripts" (compiler_safe_outputs_job.go:782)
  • "Write Safe Outputs Config"
  • "Generate Safe Outputs MCP Server Config"
  • "Start Safe Outputs MCP HTTP Server"
  • "Process Safe Outputs"
  • "Upload Safe Outputs Items"
  • "Upload Safe Outputs Assets"

Issue:
The glossary defines "Custom Safe Outputs" (under safe-outputs.jobs:) as the feature this step configures. All other generated step names use "Safe Outputs" consistently. The lone "Safe Job" term is out of step with established naming conventions.

Suggested improvement:

"Configure Safe Job Environment Variables"
→ "Configure Safe Outputs Job Environment Variables"

Or, shorter:

→ "Configure Custom Job Environment Variables"

The first option mirrors the existing "Safe Outputs" prefix pattern most closely.

Glossary reference: Safe Outputs, Custom Safe Outputs


Agentic Task Description

To fix this step name:

  1. Edit pkg/workflow/safe_jobs.go — update the string literal at line 244 from "Configure Safe Job Environment Variables" to "Configure Safe Outputs Job Environment Variables"
  2. Update tests — search for the old string in *_test.go files and update assertions
  3. Recompile affected workflows: gh aw compile on the source .md files for daily-choice-test, mcp-inspector, notion-issue-summary, smoke-copilot-arm, smoke-copilot
  4. Verify compiled .lock.yml files contain the new step name

Related Files

  • Compiler source: pkg/workflow/safe_jobs.go:244
  • Affected workflows: daily-choice-test.lock.yml, mcp-inspector.lock.yml, notion-issue-summary.lock.yml, smoke-copilot-arm.lock.yml, smoke-copilot.lock.yml
  • Project glossary: docs/src/content/docs/reference/glossary.md

Priority

This issue is High Priority — it introduces a terminology mismatch for a specific Safe Outputs feature area that could confuse contributors reading step summaries or workflow logs.


AI generated by Step Name Alignment for daily maintenance

Generated by Step Name Alignment · ● 226.4K ·

  • expires on Apr 22, 2026, 7:46 PM UTC

Metadata

Metadata

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions