[q] fix(cache-strategy-analyzer): recognize run_id+restore-keys as valid 'last one wins' pattern

[github-actions]

Summary

The daily-cache-strategy-analyzer was incorrectly classifying any cache key containing run_id as 🔴 Critical severity.

The correct pattern for a "last one wins" cache system is:

• Cache key: <prefix>-${{ github.run_id }} (unique per run, avoids collisions)
• Restore keys: <prefix>- (falls back to the most recent previous entry)

This means each run always saves its state uniquely, and always restores the most recent available state — achieving "last write wins" without stale data or key collisions.

Changes

.github/workflows/daily-cache-strategy-analyzer.md

• Phase 2.3 — Clarified that run_id keys are only misconfigured when there are no restore-key fallbacks. Added an explicit note explaining the "last one wins" pattern.
• Phase 4 severity table — Critical criterion now requires run_id key without restore-keys.
• Issue template — Recommended fix updated to guide toward adding restore-keys rather than removing run_id.
• Best practices list — Item 1 updated to match.

References

• Triggered by comment on [cache-strategy] Daily Cache Strategy Analyzer - Issue Group #28728 by @pelikhan

• Fixes [cache-strategy] Daily Cache Strategy Analyzer - Issue Group #28728

---

Warning

Protected Files — Push Permission Denied

This was originally intended as a pull request, but the patch modifies protected files. A human must create the pull request manually.

Protected files

• .github/workflows/daily-cache-strategy-analyzer.md

The push was rejected because GitHub Actions does not have workflows permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.

Create the pull request manually

# Download the patch from the workflow run
gh run download 25035367976 -n agent -D /tmp/agent-25035367976

# Create a new branch
git checkout -b q/fix-cache-strategy-analyzer-runid-detection-14332ba1ba8749cd main

# Apply the patch (--3way handles cross-repo patches)
git am --3way /tmp/agent-25035367976/aw-q-fix-cache-strategy-analyzer-runid-detection.patch

# Push the branch and create the pull request
git push origin q/fix-cache-strategy-analyzer-runid-detection-14332ba1ba8749cd
gh pr create --title '[q] fix(cache-strategy-analyzer): recognize run_id+restore-keys as valid 'last one wins' pattern' --base main --head q/fix-cache-strategy-analyzer-runid-detection-14332ba1ba8749cd --repo github/gh-aw

🎩 Equipped by Q · ● 685.4K · ◷

• expires on Apr 30, 2026, 5:25 AM UTC