Skip to content

safe_outputs add_comment hard-fails on locked source PR (pr-docs-check recurring failures) #34998

@IEvangelist

Description

@IEvangelist

Summary

safe_outputs fails the entire workflow when a comment-target issue/PR is locked.

In microsoft/aspire pr-docs-check workflows (milestone 13.4 analysis), this is currently the dominant deterministic failure signature.

Impact observed

  • Signature: safe-outputs-source-pr-locked-comment
  • Runs impacted in sample set: 57
  • Affected source PRs: 16715

Representative failing runs:

Typical error:
Failed to add comment: Unable to create comment because issue is locked.

Expected behavior

If comment posting fails specifically because the issue/PR is locked, safe_outputs should treat that as non-fatal (warning/skip) and continue processing other outputs, instead of failing the whole job.

Why this matters

For automated agentic workflows, locked source PRs are a valid repo state. Hard-failing on comment emission turns a notification side effect into a release-blocking workflow failure.

Metadata

Metadata

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions