Skip to content

[deep-report] Schema: add additionalProperties:false to 3 input subschemas (typos pass silently) #35735

@github-actions

Description

@github-actions

Problem

Three user-input subschemas in pkg/parser/schemas/main_workflow_schema.json declare properties but omit additionalProperties: false, so misspelled input keys validate silently instead of erroring:

Subschema path Defined keys
properties.on.oneOf[1].properties.workflow_call.oneOf[1].properties.inputs.additionalProperties type, description, required, default
properties.on.oneOf[1].properties.workflow_call.oneOf[1].properties.secrets.additionalProperties description, required
properties["safe-outputs"].properties.dispatch_repository.additionalProperties.properties.inputs.additionalProperties type, description, options, required, default

The sibling input def under safe-outputs.actions.*.inputs.* already sets additionalProperties: false, so this is a clear oversight rather than intentional.

Fix

Add "additionalProperties": false to each of the three subschemas above.

Acceptance criteria

  • All three subschemas reject unknown keys
  • A workflow with a typo'd input key (e.g. requird:) now fails compilation with a clear error
  • Existing valid workflows still compile

Effort / suggested agent

~30–60 min incl. a regression test. Schema/compiler agent.

Source: [Schema Consistency] Check 2026-05-29 (discussion #35656), finding #1 (NEW).

Identified by DeepReport run §26647364565.

Generated by 🔬 DeepReport - Intelligence Gathering Agent · opus48 2.1M ·

  • expires on May 31, 2026, 4:03 PM UTC

Metadata

Metadata

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions