-
Notifications
You must be signed in to change notification settings - Fork 327
[plan] Remove gojsonschema dependency from go.mod #6404
Copy link
Copy link
Closed
Labels
Description
Objective
Remove the unmaintained github.com/xeipuuv/gojsonschema dependency from the project after successfully migrating to santhosh-tekuri/jsonschema.
Context
After migrating campaign validation to use santhosh-tekuri/jsonschema, the gojsonschema library is no longer used anywhere in the codebase and should be removed.
Prerequisites
- [plan] Migrate campaign validation from gojsonschema to santhosh-tekuri/jsonschema #6402 must be completed (campaign validation migrated)
- All tests must be passing
Implementation Steps
-
Verify no usages remain:
grep -r "gojsonschema" . --include="*.go"
Should return no results in
.gofiles (may appear in discussion/spec files which is fine) -
Remove from go.mod:
go mod tidy
This will automatically remove unused dependencies
-
Verify removal:
grep "xeipuuv/gojsonschema" go.mod go.sumShould return no results
-
Run full test suite:
make test -
Verify binary size reduction (optional):
make build ls -lh gh-aw
Files to Modify
go.mod(automatic viago mod tidy)go.sum(automatic viago mod tidy)
Acceptance Criteria
-
github.com/xeipuuv/gojsonschemanot present ingo.mod - No references to gojsonschema in any
.gofiles -
go mod tidycompletes successfully - All tests pass (
make test) - Code builds successfully (
make build)
Related to [plan] Migrate from unmaintained gojsonschema to santhosh-tekuri/jsonschema #6401
AI generated by Plan Command for discussion #6400
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Fields
Give feedbackNo fields configured for issues without a type.