Skip to content

Use expression tree builders for safe-output job conditions with always() wrapper and add complete Target support #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 22 commits into from
Oct 1, 2025
Merged

Use expression tree builders for safe-output job conditions with always() wrapper and add complete Target support #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
764314c
Initial plan
Copilot Sep 29, 2025
2572552
Update safe-output job creation functions to use BuildSafeOutputType …
Copilot Sep 29, 2025
332dfbb
Retain original base conditions AND them with BuildSafeOutputType, re…
Copilot Sep 29, 2025
e92f392
Remove always() condition and use expression trees (AndNode/OrNode) f…
Copilot Sep 29, 2025
0eb1432
Remove Target="*" special case handling - always combine with base co…
Copilot Sep 29, 2025
24695c4
Refactor job condition handling to simplify expression tree usage acr…
pelikhan Sep 29, 2025
966d44a
Merge branch 'copilot/fix-d8e61a3d-9fad-42d6-82a3-ae4872557728' of ht…
pelikhan Sep 29, 2025
0ce8e41
Remove redundant comments about job condition building in workflow files
pelikhan Sep 29, 2025
b8be7ef
Rename create_issue_comment job to add_comments and update conditions…
pelikhan Sep 29, 2025
439758f
Rename add_comments job to add_comment and simplify job conditions in…
pelikhan Sep 30, 2025
5d9c8ff
Merge remote-tracking branch 'origin/main' into copilot/fix-d8e61a3d-…
pelikhan Sep 30, 2025
90f8393
Fix tests: update job name from create_issue_comment to add_comment
Copilot Sep 30, 2025
60205df
Add Target support to add-labels similar to update-issue
Copilot Sep 30, 2025
efeae11
Fix publish_assets.go to use correct output type "upload-asset"
Copilot Sep 30, 2025
3b4a88b
Add Target support to add_labels.js JavaScript implementation
Copilot Sep 30, 2025
3dc2e95
Add nil checks before accessing Target field in add_comment and updat…
Copilot Sep 30, 2025
995b2d0
Wrap BuildSafeOutputType conditions with always() to run even when ag…
Copilot Oct 1, 2025
bac0436
Run format, lint, and recompile workflows
Copilot Oct 1, 2025
0efa418
Merge branch 'main' into copilot/fix-d8e61a3d-9fad-42d6-82a3-ae487255…
pelikhan Oct 1, 2025
0551bca
Fix missing_tool job to use BuildSafeOutputType with correct output t…
Copilot Oct 1, 2025
c91e135
Merge branch 'main' of https://github.com/githubnext/gh-aw into copil…
Copilot Oct 1, 2025
1fbb3fe
Merge main, run format, lint, and recompile workflows
Copilot Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/artifacts-summary.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions .github/workflows/ci-doctor.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/dev.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions .github/workflows/tidy.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 16 additions & 9 deletions pkg/cli/workflows/test-all.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-claude-max-patch-size.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-missing-tool.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions pkg/cli/workflows/test-claude-patch-size-exceeded.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-claude-playwright-accessibility-contrast.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pkg/cli/workflows/test-claude-playwright-screenshots.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-claude-safe-jobs.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-copilot-max-patch-size.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-copilot-missing-tool.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions pkg/cli/workflows/test-copilot-patch-size-exceeded.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pkg/cli/workflows/test-copilot-playwright-screenshots.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/cli/workflows/test-copilot-safe-jobs.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pkg/cli/workflows/test-playwright-args.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading