Fix expiration detection for quoted footers and legacy format#11036
Merged
Fix expiration detection for quoted footers and legacy format#11036
Conversation
- Updated EXPIRATION_PATTERN to require blockquote prefix ("> ")
- Added LEGACY_EXPIRATION_PATTERN to match old format without HTML comment
- Updated extractExpirationDate to handle both new and legacy formats
- Added comprehensive tests for both patterns and formats
- Fixes issue #10667 detection - will now be closed by maintenance workflow
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review agentic-maintenance.yml for issue expiration
Fix expiration detection for quoted footers and legacy format
Jan 21, 2026
pelikhan
approved these changes
Jan 21, 2026
This was referenced Jan 21, 2026
3 tasks
pelikhan
pushed a commit
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #10667 expired Jan 20 but wasn't closed by agentic-maintenance. The expiration pattern didn't match blockquote-prefixed lines (
> - [x] expires...) and had no fallback for issues created before HTML comments were added.Changes
EXPIRATION_PATTERNto require blockquote prefix:/^>\s*-\s*\[x\]\s+expires\s*<!--\s*gh-aw-expires:\s*([^>]+)\s*-->/mLEGACY_EXPIRATION_PATTERNto match old format without HTML comment:/^>\s*-\s*\[x\]\s+expires\s+on\s+(.+?)\s+UTC\s*$/mextractExpirationDate()to try new format first, fall back to legacy format parsing human-readable datesExample
Both formats now work. Next maintenance run will detect and close #10667.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.