Skip to content

[tidy] Fix formatting in audit files #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Oct 2, 2025
Merged

[tidy] Fix formatting in audit files #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions pkg/cli/audit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Examples:
Args: cobra.ExactArgs(1),
Run: func(cmd *cobra.Command, args []string) {
runIDOrURL := args[0]

// Extract run ID from input (either numeric ID or URL)
runID, err := extractRunID(runIDOrURL)
if err != nil {
Expand Down Expand Up @@ -85,7 +85,7 @@ func extractRunID(input string) (int64, error) {
// - https://github.com/owner/repo/actions/runs/12345678/attempts/2
runIDPattern := regexp.MustCompile(`/actions/runs/(\d+)`)
matches := runIDPattern.FindStringSubmatch(input)

if len(matches) >= 2 {
runID, err := strconv.ParseInt(matches[1], 10, 64)
if err != nil {
Expand Down Expand Up @@ -117,14 +117,14 @@ func AuditWorkflowRun(runID int64, outputDir string, verbose bool) error {
}

runOutputDir := filepath.Join(outputDir, fmt.Sprintf("run-%d", runID))

// Check if we have locally cached artifacts first
hasLocalCache := dirExists(runOutputDir) && !isDirEmpty(runOutputDir)

// Try to get run metadata from GitHub API
run, metadataErr := fetchWorkflowRunMetadata(runID, verbose)
var useLocalCache bool

if metadataErr != nil {
// Check if it's a permission error
if isPermissionError(metadataErr) {
Expand All @@ -133,12 +133,12 @@ func AuditWorkflowRun(runID int64, outputDir string, verbose bool) error {
useLocalCache = true
} else {
// Provide helpful message about using GitHub MCP server
return fmt.Errorf("GitHub API access denied and no local cache found.\n\n" +
"To download artifacts, use the GitHub MCP server:\n\n" +
"1. Use the github-mcp-server tool 'download_workflow_run_artifacts' with:\n" +
" - run_id: %d\n" +
" - output_directory: %s\n\n" +
"2. After downloading, run this audit command again to analyze the cached artifacts.\n\n" +
return fmt.Errorf("GitHub API access denied and no local cache found.\n\n"+
"To download artifacts, use the GitHub MCP server:\n\n"+
"1. Use the github-mcp-server tool 'download_workflow_run_artifacts' with:\n"+
" - run_id: %d\n"+
" - output_directory: %s\n\n"+
"2. After downloading, run this audit command again to analyze the cached artifacts.\n\n"+
"Original error: %v", runID, runOutputDir, metadataErr)
}
} else {
Expand All @@ -159,20 +159,20 @@ func AuditWorkflowRun(runID int64, outputDir string, verbose bool) error {
fmt.Fprintln(os.Stderr, console.FormatWarningMessage("Artifact download failed due to permissions, but found locally cached artifacts. Processing cached data..."))
useLocalCache = true
} else {
return fmt.Errorf("failed to download artifacts due to permissions and no local cache found.\n\n" +
"To download artifacts, use the GitHub MCP server:\n\n" +
"1. Use the github-mcp-server tool 'download_workflow_run_artifacts' with:\n" +
" - run_id: %d\n" +
" - output_directory: %s\n\n" +
"2. After downloading, run this audit command again to analyze the cached artifacts.\n\n" +
return fmt.Errorf("failed to download artifacts due to permissions and no local cache found.\n\n"+
"To download artifacts, use the GitHub MCP server:\n\n"+
"1. Use the github-mcp-server tool 'download_workflow_run_artifacts' with:\n"+
" - run_id: %d\n"+
" - output_directory: %s\n\n"+
"2. After downloading, run this audit command again to analyze the cached artifacts.\n\n"+
"Original error: %v", runID, runOutputDir, err)
}
} else {
return fmt.Errorf("failed to download artifacts: %w", err)
}
}
}

// If using local cache without metadata, create a minimal run structure
if useLocalCache && run.DatabaseID == 0 {
run = WorkflowRun{
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/audit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func TestExtractRunID(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result, err := extractRunID(tt.input)

if tt.shouldErr {
if err == nil {
t.Errorf("Expected error but got none")
Expand Down