Skip to content

Add high-level overview sections for network isolation, safe outputs, and threat detection to security guide#1198

Merged
pelikhan merged 6 commits intomainfrom
copilot/update-security-guide-network-isolation
Oct 3, 2025
Merged

Add high-level overview sections for network isolation, safe outputs, and threat detection to security guide#1198
pelikhan merged 6 commits intomainfrom
copilot/update-security-guide-network-isolation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 3, 2025

  • Analyze existing security guide structure and identify insertion points
  • Add section on Network Isolation (covering both MCP tool network controls and engine network permissions)
  • Add section on Safe Outputs security model
  • Add section on Threat Detection system
  • Update cross-references and ensure consistency
  • Run linting and validation
  • Verify documentation builds correctly
  • Remove detailed subsections per feedback (Content Sanitization, Configuration Example, Best Practices, Detection Response Format, Configuration, Job Dependencies, Security Guidelines, Monitoring and Debugging)
  • Simplify sections to high-level overviews with links to detailed reference documentation
  • Further reduce details in Network Isolation section per feedback
Original prompt

Update security guide with a section on network isolation, safe outputs and threat detection.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits October 3, 2025 15:31
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
… security guide

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update security guide with network isolation and threat detection Update security guide with sections on network isolation, safe outputs, and threat detection Oct 3, 2025
Copilot AI requested a review from pelikhan October 3, 2025 15:39

See the [Safe Outputs Reference](/gh-aw/reference/safe-outputs/) for complete configuration details.

#### Content Sanitization
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Content Sanitization section in commit 3734e6c

- **Length and Line Limits**: Content truncated if exceeding safety thresholds (0.5MB, 65k lines)
- **Control Character Removal**: ANSI sequences and non-printable characters stripped

#### Configuration Example
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Configuration Example section in commit 3734e6c

- Each output job receives only the specific write permission it needs
- Output is validated and sanitized before any GitHub API calls

#### Best Practices
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Best Practices section (Safe Outputs) in commit 3734e6c

- Reduce false positives by considering workflow design
- Provide more accurate threat assessments

#### Detection Response Format
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Detection Response Format section in commit 3734e6c

- Safe output jobs are blocked from executing
- Logs and artifacts provide audit trail for review

#### Configuration
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Configuration section in commit 3734e6c

enabled: false # Explicitly disable (not recommended)
```

#### Job Dependencies
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Job Dependencies section in commit 3734e6c


This ensures no GitHub API write operations occur until the agent output is verified as safe.

#### Security Guidelines
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Security Guidelines section in commit 3734e6c

- **Err on the side of caution**: When uncertain, treats potential threats seriously
- **Clear, actionable feedback**: Provides specific reasons for detected threats

#### Monitoring and Debugging
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Monitoring and Debugging section in commit 3734e6c

3. Add custom detection prompt instructions to provide context
4. In rare cases, disable detection (not recommended for production)

#### Best Practices
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Best Practices section (Threat Detection) in commit 3734e6c

- **Configuration**: Top-level `network.allowed`
- **Best for**: Controlling engine access to development tools and APIs

#### Security Best Practices
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Remove section

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Security Best Practices section (Network Isolation) in commit 3734e6c

@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented Oct 3, 2025

@copilot keep the security guide as an overview and link to other in depth docs. Do not add too much details of the implentation in that page.

…Network Isolation sections

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Oct 3, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: node /home/REDACTED/.npm/_npx/aa98e6899c6baff3/node_modules/.bin/astro build (dns block)
    • Triggering command: node /home/REDACTED/work/gh-aw/gh-aw/docs/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copy link
Copy Markdown
Collaborator

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot reduce details on network section, link to other docs

…s to detailed docs

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Oct 3, 2025

@copilot keep the security guide as an overview and link to other in depth docs. Do not add too much details of the implentation in that page.

Simplified all three sections to high-level overviews with links to detailed reference documentation in commit b7f6d65. Removed implementation details, code examples, comparison tables, and troubleshooting sections. Each section now provides a concise overview and directs users to the appropriate reference docs for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: node /home/REDACTED/work/gh-aw/gh-aw/docs/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Update security guide with sections on network isolation, safe outputs, and threat detection Add high-level overview sections for network isolation, safe outputs, and threat detection to security guide Oct 3, 2025
Copilot AI requested a review from pelikhan October 3, 2025 15:57
… details

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Oct 3, 2025

@copilot reduce details on network section, link to other docs

Reduced Network Isolation section to minimal overview in commit d34eba0. Removed technical implementation details (Docker containers, proxy, iptables, ecosystem identifiers) and kept only the core concepts with links to detailed documentation.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: node /home/REDACTED/.npm/_npx/aa98e6899c6baff3/node_modules/.bin/astro build (dns block)
    • Triggering command: node /home/REDACTED/work/gh-aw/gh-aw/docs/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@pelikhan pelikhan marked this pull request as ready for review October 3, 2025 16:05
@pelikhan pelikhan merged commit 426824b into main Oct 3, 2025
@pelikhan pelikhan deleted the copilot/update-security-guide-network-isolation branch October 3, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants