Merged
Conversation
This was referenced Jan 27, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Added "noop" to autoEnabledHandlers map - Added "noop" handler to handlerRegistry - Added comprehensive test for auto-enabled handlers - Ensures noop is always available as fallback like missing_tool and missing_data Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add noop safe output type as a built-in tool
Auto-enable noop safe output handler
Jan 27, 2026
pelikhan
approved these changes
Jan 27, 2026
Contributor
|
@copilot merge main and recompile |
…-output-type # Conflicts: # .github/workflows/security-alert-burndown.campaign.lock.yml
- Merged origin/main into branch - Resolved conflict by accepting deletion of security-alert-burndown.campaign.lock.yml - Recompiled all workflows to include noop handler in auto-enabled handlers - Added new generated campaign files Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Make "noop" safe output type always enabled ✅
autoEnabledHandlersmap incompiler_safe_outputs_config.gohandlerRegistryincompiler_safe_outputs_config.goSummary
Successfully implemented the requirement that "noop" safe output type should always be enabled, just like "missing_tool" and "missing_data".
Changes Made
File:
pkg/workflow/compiler_safe_outputs_config.go"noop": truetoautoEnabledHandlersmap (line 17)handlerRegistry(lines 406-414)File:
pkg/workflow/compiler_safe_outputs_config_test.go3. Added
TestAutoEnabledHandlerstest covering all auto-enabled handlersVerification
✅ Unit Tests: All tests pass including new
TestAutoEnabledHandlers✅ Integration Tests: Existing noop and missing_tool conclusion tests pass
✅ Manual Verification: Compiled test workflow includes noop with default config
{"max":1}✅ Post-merge: Merged main branch and recompiled all workflows successfully
Handler Configuration Example
When a workflow has
safe-outputsconfigured, the compiled workflow now includes:{ "create_issue": {"max": 1}, "missing_data": {}, "missing_tool": {}, "noop": {"max": 1} }All three built-in handlers (missing_tool, missing_data, noop) are automatically enabled as fallbacks, ensuring consistent behavior across all workflows.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.