Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add compiler checks for template region commands
Add compiler validation to detect @include/@import directives inside template regions
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The compiler was not validating that
@includeand@importdirectives are used correctly with template conditional blocks. This created ambiguity because:{{#if...}}{{/if}}) are processed at runtime by GitHub ActionsSolution
Added a new validation function
validateNoIncludesInTemplateRegions()that:{{#if...}}{{/if}}template regions@includeor@importdirectivesThe validation is integrated into
ParseWorkflowFile()before include expansion, ensuring we catch issues early with the raw markdown content.Example
Before - This would compile without error (causing confusion):
{{#if github.event.issue.number}} @include shared/tools.md This creates ambiguity! {{/if}}After - Now raises a clear error:
Correct usage - Includes outside templates work as expected:
@include shared/tools.md {{#if github.event.issue.number}} Content here is fine! {{/if}}Testing
make agent-finishvalidates all checks passFixes the issue where includes inside template regions could cause compilation or runtime confusion.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.