Make brave.md workflow strict and fix network proxy generation for MCP servers#1309
Merged
Make brave.md workflow strict and fix network proxy generation for MCP servers#1309
Conversation
- Added `strict: true` to brave.md frontmatter - Added network configuration for brave-search MCP server - Fixed hasNetworkPermissions to check network at tool level (not under mcp) - Fixed needsProxy to check for container in toolConfig before transformation - Fixed generateInlineProxyConfig to get container info before getMCPConfig transforms it - All tests passing - Proxy configuration now correctly generated in lock file Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
reviewed
Oct 7, 2025
Copilot
AI
changed the title
[WIP] Update brave.md workflow to strict mode and fix issues
Make brave.md workflow strict and fix network proxy generation for MCP servers
Oct 7, 2025
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: Make brave.md workflow strict and fix issues
Completed
strict: trueto brave.md frontmatterChanges Made
strict: trueand network configuration with allowed domainshasNetworkPermissionsto check network field at tool level onlyneedsProxyto check for container in original toolConfiggenerateInlineProxyConfigto extract container info before getMCPConfig transforms itThe workflow now compiles successfully in strict mode and generates proper network proxy configuration with Squid for the brave-search MCP server.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.