Consolidate create-project into unified safe output handler #13097
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Move create-project from projectHandlerRegistry to handlerRegistry - Update unified handler manager to handle create-project - Update project handler manager to remove create-project - Update compiler logic to exclude create-project from project handler check - Update permissions to include create-project in unified handler section - Update tests to reflect create-project now in unified handler - Verified create-project config correctly added to handler config JSON Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
| // Note: create_project, update_project and create_project_status_update are handled by the unified handler, | ||
| // not the separate project handler manager, so they are included in this registry. | ||
| "create_project": func(cfg *SafeOutputsConfig) map[string]any { | ||
| if cfg.CreateProjects == nil { |
There was a problem hiding this comment.
@copilot use singular to match safe output name
Updated TestHandlerManagerOrderWithProjects to use copy_project instead of create_project since create-project is now handled by the unified handler, not the project handler manager. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated buildHandlerManagerStep to only reference process_project_safe_outputs.outputs.temporary_project_map when copy_project is configured, since create_project, update_project, and create_project_status_update are now handled by the unified handler and don't need the project handler's outputs. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Agent Container Tool Check
Result: 10/12 tools available ❌ FAIL - 2 tool(s) missing (java, dotnet) Summary:
|
Smoke Test: Claude ✅PR Titles (merged):
Test Results:
Overall: PASS
|
|
🧪 Smoke Test Results - Run 21563357087 PRs tested: #13097, #13094 Overall: PARTIAL PASS
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
PRs: Consolidate create-project into unified safe output handler | Align Go frontmatter hash with JavaScript text-based implementation
|
Move
create-projectfrom the separate project handler manager step to the unified handler, matching the existing pattern forupdate-projectandcreate-project-status-update.Changes
Registry migration (
compiler_safe_outputs_config.go):create_projectbuilder fromprojectHandlerRegistry→handlerRegistrycopy_projectremains in the project handler managerCompiler logic (
compiler_safe_outputs_job.go,compiler_safe_outputs_steps.go):hasProjectHandlerManagerTypesto only check forcopy_projectGH_AW_TEMPORARY_PROJECT_MAPreference to only be set whencopy_projectis configuredJavaScript handlers:
create_projectfromsafe_output_project_handler_manager.cjshandler mapsafe_output_unified_handler_manager.cjs(already supported)Tests:
copy_projectinsteadImpact
Workflows using only
create-project(orupdate-project/create-project-status-update) no longer generate a separate project handler manager step. The unified handler processes all three project operations using the standardGH_AW_GITHUB_TOKEN, with project-specific token override via handler config when needed.Before: Workflows with
create-projecthad two steps (project handler + unified handler)After: Single unified handler step unless
copy-projectis also configuredOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.