Use XML comment markers for agentic workflow detection

[Copilot]

The agentic maintenance workflow's expired entity detection needs to identify issues created by agentic workflows. Based on code review feedback, this now uses XML comment markers instead of text pattern matching.

Change

Updated detection logic in expired_entity_search_helpers.cjs to use XML comment markers:

// Before: text pattern matching
const agenticPattern = /^> AI generated by/m;
const isAgenticWorkflow = entity.body && agenticPattern.test(entity.body);

// After: XML comment marker detection
const hasWorkflowId = entity.body && entity.body.includes("gh-aw-workflow-id:");
const hasAgenticWorkflow = entity.body && entity.body.includes("gh-aw-agentic-workflow:");
const isAgenticWorkflow = hasWorkflowId || hasAgenticWorkflow;

This approach is more reliable and consistent with other workflow detection patterns in the codebase (e.g., close_older_issues.cjs).

Why This Matters

XML comment markers (<!-- gh-aw-workflow-id: ... --> or <!-- gh-aw-agentic-workflow: ... -->) are the authoritative identifiers for agentic workflow-generated content. Issues without these markers are not managed by agentic workflows and should not be auto-closed.

Tests Updated

• Added XML comment markers to all existing test cases
• Added test confirming issues without XML markers are correctly filtered out
• Added specific tests for both gh-aw-workflow-id and gh-aw-agentic-workflow marker types

Issue #12669 Context

Issue #12669 was not detected because it lacks XML comment markers. This is correct behavior - without these markers, the issue is not managed by an agentic workflow and should not be auto-closed.

Original prompt

Investigate why this issue was not detected and closed by the agentic maintenance workflow.

#12669

See ephemerals.cjs

Add test with this issue markdown. It is expired.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[pelikhan]

@copilot use the XML comment with workflow id or workflow name instead.

[Copilot]

Updated to use XML comment markers (gh-aw-workflow-id: or gh-aw-agentic-workflow:) instead of text patterns. This matches the pattern used in other parts of the codebase like close_older_issues.cjs. Changed in commit 0566d31.

[pelikhan]

@copilot the helper to detect if a text is agentically generated should be based on xml comments and it should be a helper function in the JavaScript file that creates the xml comment. Add tests.

[github-actions]

Smoke Test: Claude - 21597335533

Last 2 Merged PRs:

• Refactor project URLs and GitHub token in workflow #13305: Refactor project URLs and GitHub token in workflow
• Add step summary for PR checkout failures #13308: Add step summary for PR checkout failures

Test Results:
✅ GitHub MCP Testing
✅ Safe Inputs GH CLI Testing
✅ Serena MCP Testing
✅ Make Build Testing
✅ Playwright Testing
✅ Tavily Web Search Testing
✅ File Writing Testing
✅ Bash Tool Testing
✅ Discussion Interaction Testing

Overall Status: PASS ✅

AI generated by Smoke Claude