Disable GitHub App usage #13362
Merged
Disable GitHub App usage #13362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes GitHub App token generation and usage from multiple workflow files to enhance security and simplify configuration. The changes eliminate the need for app credentials (APP_ID and APP_PRIVATE_KEY) by replacing them with a fallback chain of standard GitHub tokens.
Changes:
- Removed GitHub App token generation and invalidation steps from all affected workflows
- Replaced GitHub App token references with fallback chain:
GH_AW_GITHUB_MCP_SERVER_TOKEN || GH_AW_GITHUB_TOKEN || GITHUB_TOKEN - Commented out GitHub App configuration in shared workflow files
- Removed APP_PRIVATE_KEY from secret redaction lists
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/smoke-claude.lock.yml |
Removed GitHub App token generation/invalidation for MCP server authentication; replaced with token fallback chain |
.github/workflows/shared/safe-output-app.md |
Commented out GitHub App configuration for safe outputs |
.github/workflows/shared/github-mcp-app.md |
Commented out GitHub App configuration for GitHub MCP server |
.github/workflows/daily-testify-uber-super-expert.lock.yml |
Removed GitHub App token generation/invalidation steps; replaced token references with fallback chain |
.github/workflows/daily-file-diet.lock.yml |
Removed GitHub App token generation/invalidation steps; replaced token references with fallback chain |
.github/workflows/changeset.lock.yml |
Removed GitHub App token generation/invalidation steps; replaced token references with fallback chain and github.token for git operations |
.github/workflows/artifacts-summary.lock.yml |
Removed GitHub App token generation/invalidation steps; replaced token references with fallback chain |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of GitHub App tokens from the workflow to enhance security and simplify the configuration. This change eliminates the need for app credentials in the workflow.