Fix mcp inspect to apply imports before extracting MCP configurations#1359
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix import application before launching mcps
Fix Oct 8, 2025
mcp inspect to apply imports before extracting MCP configurations
pelikhan
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
mcp inspectcommand was not processing theimports:field in workflow frontmatter before extracting MCP server configurations. This meant that MCP servers defined in imported files were invisible to the inspect command, even though they would be properly included during workflow compilation.For example, the
pdf-summary.mdworkflow importsshared/markitdown-mcp.mdwhich defines amarkitdownMCP server:Running
gh aw mcp inspect pdf-summarywould fail to find themarkitdownMCP server because imports were not being processed.Solution
Updated both
InspectWorkflowMCPandspawnMCPInspectorfunctions to:parser.ProcessImportsFromFrontmatterWithManifest(the same function used by the workflow compiler)This ensures
mcp inspectsees the complete MCP server configuration, including servers defined in imported files.Key Changes
MergeTools,MergeMCPServers) inpkg/workflow/imports.gofor reuse across the codebaseapplyImportsToFrontmatterhelper to merge imported configurations into frontmatter before extractionTesting
TestApplyImportsToFrontmatterto verify import merging logicpdf-summary) correctly find imported MCP serversNow running
gh aw mcp inspect pdf-summarycorrectly finds and inspects themarkitdownMCP server imported fromshared/markitdown-mcp.md.Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.