Fix test coverage tracking by uploading artifacts on failure#13706
Merged
Fix test coverage tracking by uploading artifacts on failure#13706
Conversation
Contributor
🔍 PR Triage ResultsCategory: test | Risk: low | Priority: 52/100 Scores Breakdown
📋 Recommended Action: deferThis is a WIP PR with no actual code changes yet. The PR is in draft mode and appears to be in the planning phase. Should be deferred until actual test fixes are implemented and the draft status is removed. Triaged by PR Triage Agent on 2026-02-04T12:20:43Z
|
The canary_go job checks test coverage by analyzing test result artifacts. When integration tests fail, the artifact upload was skipped, causing canary_go to report missing test coverage. This fix adds `if: always()` to both unit and integration test result uploads to ensure artifacts are created even when tests fail, allowing canary_go to accurately track which tests are being executed. Fixes the 137 missing tests issue in CI. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing tests in the codebase
Fix test coverage tracking by uploading artifacts on failure
Feb 4, 2026
pelikhan
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes test coverage tracking in the CI pipeline by ensuring test result artifacts are uploaded even when tests fail. Previously, the canary_go job reported 137 missing tests because artifacts weren't uploaded from failed test jobs, causing incorrect coverage analysis.
Changes:
- Added
if: always()condition to unit test result artifact upload step - Added
if: always()condition to integration test result artifact upload step
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canary_go job reported 137 missing tests because test result artifacts were not uploaded when test jobs failed, causing coverage analysis to incorrectly conclude tests were never executed.
Changes
if: always()to unit and integration test result artifact uploads in.github/workflows/ci.ymlThis ensures test execution data is captured regardless of test outcomes, allowing accurate coverage tracking across all CI jobs.
Note
The "CLI Completion & Other" integration job shows package-level failure despite all individual tests passing. This test infrastructure issue requires separate investigation.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.