Add AWF --skip-pull flag and pre-download agent/squid images#13756
Add AWF --skip-pull flag and pre-download agent/squid images#13756
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR optimizes the AWF (Agentic Workflow Firewall) integration by pre-downloading Docker container images and using the --skip-pull flag to avoid redundant pulls at runtime.
Changes:
- Added
DefaultFirewallRegistryconstant for AWF container registry - Implemented AWF image pre-download in docker.go for both squid (proxy) and agent-act containers
- Added
--skip-pullflag to AWF invocations in all three engine files (copilot, claude, codex)
Reviewed changes
Copilot reviewed 149 out of 149 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/constants/constants.go | Added DefaultFirewallRegistry constant for AWF container registry URL |
| pkg/workflow/docker.go | Added logic to collect AWF squid and agent-act images when firewall is enabled |
| pkg/workflow/copilot_engine_execution.go | Added --skip-pull flag to AWF args |
| pkg/workflow/claude_engine.go | Added --skip-pull flag to AWF args |
| pkg/workflow/codex_engine.go | Added --skip-pull flag to AWF args |
| .github/workflows/*.lock.yml (multiple files) | Updated all workflow lock files with pre-downloaded AWF images and --skip-pull flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
Agent Container Tool Check
Result: 10/12 tools available Note: Java and .NET runtimes are not available in the container.
|
Smoke Test: Copilot - 21681629889PRs Tested:
Results: ✅ PASS - All tests passed
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
AWF was pulling container images at runtime during agent execution. This change pre-downloads AWF images (agent and squid proxy) and uses
--skip-pullto avoid runtime pulls, matching how MCP gateway and GitHub MCP server images are already handled.Changes
pkg/constants/constants.go: AddDefaultFirewallRegistryconstant forghcr.io/github/gh-aw-firewallpkg/workflow/docker.go: Collect AWF squid and agent-act images when firewall is enabledpkg/workflow/{copilot,claude,codex}_engine*.go: Add--skip-pullflag to AWF argsGenerated workflow example
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.