Add symbol search verification to smoke workflow Serena MCP tests#13955
Add symbol search verification to smoke workflow Serena MCP tests#13955
Conversation
After initializing the serena MCP with activate_project, workflows now search for symbols using find_symbol tool and verify at least 3 symbols are found. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request enhances the smoke test workflows by adding symbol search verification to the Serena MCP testing steps. After initializing the workspace with activate_project, the workflows now verify that Serena's language server integration is working correctly by searching for symbols and confirming that at least 3 symbols are found.
Changes:
- Expanded the "Serena MCP Testing" step in all 4 smoke workflow files to include symbol search verification after project initialization
- Split the single-line instruction into a multi-line bulleted format for better readability
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/smoke-opencode.md |
Added find_symbol verification step to test Serena MCP symbol search functionality |
.github/workflows/smoke-copilot.md |
Added find_symbol verification step to test Serena MCP symbol search functionality |
.github/workflows/smoke-codex.md |
Added find_symbol verification step to test Serena MCP symbol search functionality |
.github/workflows/smoke-claude.md |
Added find_symbol verification step to test Serena MCP symbol search functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||
| 3. **Serena MCP Testing**: | ||
| - Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results |
There was a problem hiding this comment.
The phrase "(find which tool to call)" is somewhat ambiguous. It's unclear whether this means:
- Find which tool to use for searching symbols (confusing, since the instruction already says to use
find_symbol) - Find symbols that represent callable functions/tools
Consider clarifying this instruction. For example: "use the find_symbol tool to search for function or method symbols" or "use the find_symbol tool without any specific query to discover available symbols".
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | |
| - After initialization, use the `find_symbol` tool to search for function or method symbols and verify that at least 3 symbols are found in the results |
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||
| 3. **Serena MCP Testing**: | ||
| - Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results |
There was a problem hiding this comment.
The phrase "(find which tool to call)" is somewhat ambiguous. It's unclear whether this means:
- Find which tool to use for searching symbols (confusing, since the instruction already says to use
find_symbol) - Find symbols that represent callable functions/tools
Consider clarifying this instruction. For example: "use the find_symbol tool to search for function or method symbols" or "use the find_symbol tool without any specific query to discover available symbols".
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | |
| - After initialization, use the `find_symbol` tool to search for function or method symbols and verify that at least 3 symbols are found in the results |
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools or the safeinputs-go/safeinputs-make tools from the go-make shared workflow) | ||
| 3. **Serena MCP Testing**: | ||
| - Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools or the safeinputs-go/safeinputs-make tools from the go-make shared workflow) | ||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results |
There was a problem hiding this comment.
The phrase "(find which tool to call)" is somewhat ambiguous. It's unclear whether this means:
- Find which tool to use for searching symbols (confusing, since the instruction already says to use
find_symbol) - Find symbols that represent callable functions/tools
Consider clarifying this instruction. For example: "use the find_symbol tool to search for function or method symbols" or "use the find_symbol tool without any specific query to discover available symbols".
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | |
| - After initialization, use the `find_symbol` tool to search for function or method symbols and verify that at least 3 symbols are found in the results |
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||
| 3. **Serena MCP Testing**: | ||
| - Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results |
There was a problem hiding this comment.
The phrase "(find which tool to call)" is somewhat ambiguous. It's unclear whether this means:
- Find which tool to use for searching symbols (confusing, since the instruction already says to use
find_symbol) - Find symbols that represent callable functions/tools
Consider clarifying this instruction. For example: "use the find_symbol tool to search for function or method symbols" or "use the find_symbol tool without any specific query to discover available symbols".
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | |
| - After initialization, use the `find_symbol` tool to search for function or method symbols (i.e., discover callable Serena tools) and verify that at least 3 symbols are found in the results |
Smoke test workflows now verify Serena MCP functionality by searching for symbols after initialization.
Changes
smoke-claude.md,smoke-copilot.md,smoke-codex.md,smoke-opencode.md)activate_projectinitialization, workflows now callfind_symbolExample
This ensures Serena's language server integration is working correctly beyond just project activation.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.