[WIP] Fix plugin validation error for Claude and Codex#14557
Closed
[WIP] Fix plugin validation error for Claude and Codex#14557
Conversation
- Set supportsPlugins: true for Claude and Codex engines - Add plugin installation steps to Claude and Codex GetInstallationSteps() - Update tests to expect plugin support from Claude and Codex - Add regression test for validation error message listing all supported engines - Update TestOtherEnginesNoPluginSupport to TestEnginesWithPluginSupport Fixes #34439 - CI Failure Investigation - Run #34439 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Plugin Validation for Claude and Codex Engines
Plan
supportsPlugins: truefor Claude engine inpkg/workflow/claude_engine.gosupportsPlugins: truefor Codex engine inpkg/workflow/codex_engine.govalidatePluginSupporterror message listing all supported enginesmake agent-finishbefore final commitContext
The issue #34439 identified that Claude and Codex engines have plugin installation code (
GeneratePluginInstallationSteps) but theirSupportsPlugins()method returns false, causing validation to reject plugins. This PR:supportsPlugins: truefor Claude and Codex enginesChanges Made
supportsPlugins: true, add plugin installation in GetInstallationSteps()supportsPlugins: true, add plugin installation in GetInstallationSteps()Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.