[WIP] Fix failing GitHub Actions workflow Integration: Workflow Compiler #14792
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
deleted the
copilot/fix-github-actions-workflow-060f18ce-b517-44d2-b34f-0a1b271bb746
branch
Copilot stopped work on behalf of
pelikhan due to an error
February 10, 2026 15:15
Contributor
There was a problem hiding this comment.
Pull request overview
Updates workflow compiler integration tests to align with the current pinned SHAs in pkg/workflow/data/action_pins.json, fixing failures caused by outdated hardcoded hashes.
Changes:
- Update expected
actions/setup-nodepinned SHA inTestCompileWorkflowWithRuntimesAppliedToSteps. - Update expected
actions/setup-gopinned SHA inTestCompileWorkflowWithGoRuntimeWithoutGoMod.
Comments suppressed due to low confidence (1)
pkg/workflow/runtime_integration_test.go:360
- This test hardcodes the
actions/setup-gopinned SHA, which will require future manual updates wheneveraction_pins.jsonchanges. To keep the test stable while still validating pinning, compute the expected SHA/reference from the pins (e.g., resolveactions/setup-go@v6throughGetActionPinWithData) and assert against the computed value.
if !strings.Contains(lockStr, "actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5") {
t.Error("Expected actions/setup-go action in lock file")
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Verify that Node.js setup step is included with version 22 | ||
| if !strings.Contains(lockStr, "actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f") { | ||
| if !strings.Contains(lockStr, "actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238") { |
There was a problem hiding this comment.
These integration assertions hardcode the pinned commit SHA. This has already proven brittle when action_pins.json changes; consider deriving the expected SHA via the same pin-resolution code used by the compiler (e.g., resolve actions/setup-node@v6 through GetActionPinWithData / pins data) and asserting against that value instead of an inlined hash.
This issue also appears on line 358 of the same file.
Suggested change
| if !strings.Contains(lockStr, "actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238") { | |
| if !strings.Contains(lockStr, "actions/setup-node@") { |
pelikhan
added a commit
that referenced
this pull request
Feb 10, 2026
* updated pins * [WIP] Fix integration tests for updated pins (#14791) * Initial plan * Initial plan for fixing integration tests Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Update integration tests with new action pins Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * [WIP] Fix failing GitHub Actions workflow Integration: Workflow Compiler (#14792) * Initial plan * Update action pin SHAs in runtime integration tests Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * [WIP] Fix failing GitHub Actions workflow runtime and setup (#14796) * Initial plan * Fix TestRuntimeSetupIntegration by updating setup-node SHA Update the test expectation to use the current SHA for actions/setup-node@v6.2.0 (6044e13b5dc448c55e2357c09f80417699197238) instead of the outdated SHA (395ad3262231945c25e8478fd5baf05154b1d79f). The action_pins.json file was recently updated with newer action SHAs, and this test needed to be synchronized. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add retry logic for transient GitHub API errors in live integration test (#14799) * Initial plan * Add retry logic for transient GitHub API errors in frontmatter hash test Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Address code review feedback: extract retry config constants and scope core mock Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Workflow Compiler Integration Tests
The tests
TestCompileWorkflowWithRuntimesAppliedToStepsandTestCompileWorkflowWithGoRuntimeWithoutGoModare failing because they check for outdated action SHA hashes that no longer match the current action pins.Root Cause
pkg/workflow/data/action_pins.jsonactions/setup-node: Old SHA395ad3262231945c25e8478fd5baf05154b1d79f→ Current SHA6044e13b5dc448c55e2357c09f80417699197238(v6.2.0)actions/setup-go: Old SHA4dc6199c7b1a012772edbd06daecab0f50c9053c→ Current SHA7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5(v6.2.0)Plan
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.