Skip to content

Fix integration test after jq removal from MCP logs guardrail#14891

Merged
pelikhan merged 2 commits intocopilot/remove-jq-arguments-supportfrom
copilot/fix-tests-please-work
Feb 11, 2026
Merged

Fix integration test after jq removal from MCP logs guardrail#14891
pelikhan merged 2 commits intocopilot/remove-jq-arguments-supportfrom
copilot/fix-tests-please-work

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

PR #14887 removed jq support from MCP server tools, including the SuggestedQueries field from MCPLogsGuardrailResponse. The integration test still referenced this removed field, causing a build failure in CI.

Changes

  • Removed test assertions for guardrail.SuggestedQueries field (lines 93-95, 106-113)
  • Test now validates only schema structure and message content

The guardrail response structure after jq removal:

type MCPLogsGuardrailResponse struct {
    Message         string         `json:"message"`
    OutputTokens    int            `json:"output_tokens"`
    OutputSizeLimit int            `json:"output_size_limit"`
    Schema          LogsDataSchema `json:"schema"`
    // SuggestedQueries removed - no longer needed without jq support
}
Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/21893400216/job/63204788705#step:10:1
Fix tests


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Remove references to SuggestedQueries field which was removed when
jq support was removed from MCP server tools. The test was checking
for suggested jq queries which are no longer part of the guardrail
response structure.

Fixes build failure in CI workflow run 21893400216.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing tests in the test suite Fix integration test after jq removal from MCP logs guardrail Feb 11, 2026
Copilot AI requested a review from pelikhan February 11, 2026 05:29
@pelikhan pelikhan marked this pull request as ready for review February 11, 2026 05:39
Copilot AI review requested due to automatic review settings February 11, 2026 05:39
@pelikhan pelikhan merged commit 21c7046 into copilot/remove-jq-arguments-support Feb 11, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/fix-tests-please-work branch February 11, 2026 05:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an integration test failure that occurred after PR #14887 removed jq filter support from MCP server tools. The SuggestedQueries field was removed from the MCPLogsGuardrailResponse struct as part of that change, but the integration test still contained assertions validating this field, causing build failures in CI.

Changes:

  • Removed test assertions for the deleted SuggestedQueries field from the logs guardrail integration test
  • Test now validates only the fields that remain in the struct: message content, schema structure, and expected schema fields

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants