Refactor GitHub CLI wrappers to eliminate duplication

[Copilot]

Five GitHub CLI wrapper functions contained duplicate token configuration and spinner logic across ~50 lines.

Changes

Extracted shared implementations:

• setupGHCommand(ctx, args...) - Consolidates token environment setup for ExecGH and ExecGHContext
• runGHWithSpinner(msg, combined, args...) - Consolidates spinner display for RunGH and RunGHCombined

Before:

func ExecGH(args ...string) *exec.Cmd {
    ghToken := os.Getenv("GH_TOKEN")
    githubToken := os.Getenv("GITHUB_TOKEN")
    // ... 20 lines of token handling ...
}

func ExecGHContext(ctx context.Context, args ...string) *exec.Cmd {
    ghToken := os.Getenv("GH_TOKEN")
    githubToken := os.Getenv("GITHUB_TOKEN")
    // ... 20 identical lines ...
}

After:

func setupGHCommand(ctx context.Context, args ...string) *exec.Cmd {
    // Single implementation of token handling
}

func ExecGH(args ...string) *exec.Cmd {
    return setupGHCommand(nil, args...)
}

func ExecGHContext(ctx context.Context, args ...string) *exec.Cmd {
    return setupGHCommand(ctx, args...)
}

Public API signatures unchanged. 64+ call sites require no modifications.

Original prompt

Review and refactor/mergr duplicate functions

Functions to Document

ExecGH (line 25) - Basic gh CLI execution with token handling
ExecGHContext (line 59) - Context-aware variant
ExecGHWithOutput (line 91) - Captures and returns output
RunGH (line 103) - Different execution semantics
RunGHCombined (line 125) - Combined stdout/stderr handling

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR refactors the GitHub CLI wrapper utilities in pkg/workflow by extracting shared logic for command setup (token/env handling) and spinner-wrapped execution, while keeping the public API unchanged.

Changes:

• Extracted setupGHCommand(ctx, args...) to centralize exec.Cmd creation and GH token environment behavior for ExecGH/ExecGHContext.
• Extracted runGHWithSpinner(msg, combined, args...) to centralize spinner + Output/CombinedOutput behavior for RunGH/RunGHCombined.
• Updated/expanded unit tests and migrated assertions to testify (assert/require).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
pkg/workflow/github_cli.go	Introduces shared helpers for gh command setup and spinner execution; updates wrappers to delegate to helpers.
pkg/workflow/github_cli_test.go	Updates assertions to testify and adds direct tests for the new helper(s).

Comments suppressed due to low confidence (1)

pkg/workflow/github_cli.go:20

• The setupGHCommand doc comment says it’s “core implementation shared by ExecGH and ExecGHContext” and implies token handling is tied to go-gh/v2 execution, but this helper only builds an exec.Cmd (and never uses go-gh/v2). Update the comment to reflect the actual behavior (exec.Command/exec.CommandContext + optional GH_TOKEN env injection), or change the implementation to truly use go-gh/v2 when tokens are available.

// setupGHCommand creates an exec.Cmd for gh CLI with proper token configuration.
// This is the core implementation shared by ExecGH and ExecGHContext.
// When ctx is nil, it uses exec.Command; when ctx is provided, it uses exec.CommandContext.
func setupGHCommand(ctx context.Context, args ...string) *exec.Cmd {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

These log lines claim the command is being run “via go-gh/v2”, but the code path is always exec.Command/exec.CommandContext. This is misleading for debugging/observability; consider changing the message to reflect the real execution mechanism (or refactor to actually route through go-gh/v2 here).

This issue also appears on line 17 of the same file.

[Copilot]

This test restores GH_TOKEN/GITHUB_TOKEN by always calling os.Setenv with the prior value. If the variable was originally unset, this will incorrectly leave it set to an empty string for subsequent tests. Capture whether the vars were set (os.LookupEnv) and Unsetenv when they weren’t, or use t.Setenv for automatic cleanup.

Suggested change

	originalGHToken := os.Getenv("GH_TOKEN")
	originalGitHubToken := os.Getenv("GITHUB_TOKEN")
	defer func() {
	os.Setenv("GH_TOKEN", originalGHToken)
	os.Setenv("GITHUB_TOKEN", originalGitHubToken)
	originalGHToken, ghTokenWasSet := os.LookupEnv("GH_TOKEN")
	originalGitHubToken, githubTokenWasSet := os.LookupEnv("GITHUB_TOKEN")
	defer func() {
	if ghTokenWasSet {
	_ = os.Setenv("GH_TOKEN", originalGHToken)
	} else {
	_ = os.Unsetenv("GH_TOKEN")
	}
	if githubTokenWasSet {
	_ = os.Setenv("GITHUB_TOKEN", originalGitHubToken)
	} else {
	_ = os.Unsetenv("GITHUB_TOKEN")
	}

[Copilot]

This “helper exists” test shells out to the real gh binary (gh auth status) and then ignores the returned error. That makes the unit test non-deterministic (depends on gh being installed/configured and can be slow/flaky) while also not asserting any behavior. Prefer a deterministic approach (e.g., point PATH to a small stub gh script/binary in a temp dir and assert Output vs CombinedOutput semantics), or drop this test and rely on tests that don’t execute external commands.