test: avoid flaky read-only dir assertion in extractZipFile #15312
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelikhan
approved these changes
Feb 13, 2026
pelikhan
pushed a commit
that referenced
this pull request
Feb 13, 2026
…15319) * Add refiner workflow for automated code style and security analysis (#15307) * test: avoid flaky readonly dir assertion in extractZipFile (#15312) * docs: add unassign-from-user safe output documentation (#15310) * Fix TypeScript type errors in error handling for unknown types (#15308) * Initial plan --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mark L <73659136+liuxiaopai-ai@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pelikhan
pushed a commit
that referenced
this pull request
Feb 13, 2026
* Clean validate_memory_files.cjs - modernize code with arrow functions and optional chaining * Fix JavaScript formatting in merge_remote_agent_github_folder.cjs (#15316) * Merge main branch and resolve conflicts in validate_memory_files.cjs (#15319) * Add refiner workflow for automated code style and security analysis (#15307) * test: avoid flaky readonly dir assertion in extractZipFile (#15312) * docs: add unassign-from-user safe output documentation (#15310) * Fix TypeScript type errors in error handling for unknown types (#15308) * Initial plan --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mark L <73659136+liuxiaopai-ai@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: JSweep Bot <jsweep-bot@github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mark L <73659136+liuxiaopai-ai@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts
TestExtractZipFileErrorHandlingto avoid a flaky assertion when running with elevated privileges.Previously, the test expected extraction into a 0555 directory to fail. When tests run as root (or on filesystems that allow writes despite mode bits), the extraction can succeed and the test fails even though behavior is correct.
Change:
This keeps the intent (document error propagation on create failure) while making the suite reliable across environments.