Skip to content

[WIP] Fix failing GitHub Actions workflow test#15573

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-github-actions-workflow-test-again
Feb 14, 2026
Merged

[WIP] Fix failing GitHub Actions workflow test#15573
pelikhan merged 3 commits intomainfrom
copilot/fix-github-actions-workflow-test-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 14, 2026

Fix LLM Gateway Support Flags for Codex and Claude Engines

Problem Analysis

The GitHub Actions test suite is failing with two test failures in TestSupportsLLMGateway and TestValidateStrictFirewall_LLMGatewaySupport:

Failing Tests:

  • TestSupportsLLMGateway/Codex_engine_supports_LLM_gateway - expects Codex to support LLM gateway (true)
  • TestSupportsLLMGateway/Claude_engine_does_not_support_LLM_gateway - expects Claude to NOT support LLM gateway (false)
  • TestValidateStrictFirewall_LLMGatewaySupport/codex_engine_with_LLM_gateway_rejects_sandbox.agent:_false_in_strict_mode - expects Codex to have LLM gateway support

Current State:

  • pkg/workflow/codex_engine.go:44 - supportsLLMGateway: false
  • pkg/workflow/claude_engine.go:33 - supportsLLMGateway: true

Expected State (from tests):

  • Codex engine should support LLM gateway (true) ✅
  • Claude engine should NOT support LLM gateway (false) ✅

Changes Made

  • Analyze failing test logs and identify root cause
  • Update Codex engine to set supportsLLMGateway: true
  • Update Claude engine to set supportsLLMGateway: false
  • Update enable_api_proxy_test.go to match new expectations
  • Update docker_api_proxy_test.go to match new expectations
  • Run selective tests to verify the fix
  • Run full test suite to ensure no regressions
  • Review and commit changes
Original prompt

Fix the failing GitHub Actions workflow test
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 63600190114
Job URL: https://github.com/github/gh-aw/actions/runs/22009453612/job/63600190114


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review February 14, 2026 02:38
Copilot AI review requested due to automatic review settings February 14, 2026 02:38
@pelikhan pelikhan enabled auto-merge (squash) February 14, 2026 02:38
@pelikhan pelikhan merged commit ecbca4f into main Feb 14, 2026
50 checks passed
@pelikhan pelikhan deleted the copilot/fix-github-actions-workflow-test-again branch February 14, 2026 02:38
Copilot AI requested a review from pelikhan February 14, 2026 02:39
Copilot stopped work on behalf of pelikhan due to an error February 14, 2026 02:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes failing test suite by correcting the LLM gateway support flags for Codex and Claude engines. The tests were expecting Codex to support LLM gateway while Claude does not, but the implementation had these flags reversed.

Changes:

  • Codex engine now correctly reports LLM gateway support (supportsLLMGateway: true), enabling api-proxy integration
  • Claude engine now correctly reports no LLM gateway support (supportsLLMGateway: false), skipping api-proxy setup
  • All related tests updated to match the corrected engine capabilities

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pkg/workflow/codex_engine.go Sets supportsLLMGateway: true to enable api-proxy sidecar for LLM API proxying through AWF firewall
pkg/workflow/claude_engine.go Sets supportsLLMGateway: false and aligns comment formatting
pkg/workflow/enable_api_proxy_test.go Updates test expectations: Claude should NOT include --enable-api-proxy flag, Codex should include it
pkg/workflow/docker_api_proxy_test.go Updates test expectations: Claude should NOT include api-proxy image, Codex should include it

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

supportsWebFetch: true, // Claude has built-in WebFetch support
supportsWebSearch: true, // Claude has built-in WebSearch support
supportsFirewall: true, // Claude supports network firewalling via AWF
supportsLLMGateway: false, // Claude does not support LLM gateway
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment in pkg/workflow/docker.go (lines 109-111) describes the api-proxy container as supporting both "Port 10000: OpenAI API proxy (for Codex)" and "Port 10001: Anthropic API proxy (for Claude)". However, with this change, only Codex will use the LLM gateway (supportsLLMGateway: true), while Claude will not (supportsLLMGateway: false). This means the api-proxy container will only be deployed when using Codex, making the Port 10001 reference potentially misleading. Consider either: (1) updating the comment to clarify that Port 10001 is for future use, (2) updating the comment to remove the Claude reference, or (3) if both engines should support LLM gateway, reconsidering whether Claude should also have supportsLLMGateway: true.

Suggested change
supportsLLMGateway: false, // Claude does not support LLM gateway
supportsLLMGateway: true, // Claude supports LLM gateway

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants