[cloclo] Add storage.googleapis.com to go ecosystem#15953
Merged
Conversation
Fixes issue #14216 where Go module downloads fail with 403 Forbidden errors because proxy.golang.org redirects to storage.googleapis.com, which was not included in the go ecosystem network allowlist. The go ecosystem identifier now includes storage.googleapis.com, allowing workflows using [defaults, go] to successfully download Go modules without manually adding the domain. Also updated the ecosystem test to verify storage.googleapis.com is properly included in the go ecosystem domains. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pelikhan
approved these changes
Feb 15, 2026
…m-ff805f9a70690fb6
pelikhan
deleted the
cloclo/add-storage-googleapis-to-go-ecosystem-ff805f9a70690fb6
branch
Contributor
There was a problem hiding this comment.
Pull request overview
Adds storage.googleapis.com to the Go ecosystem domain allowlist so Go module downloads work when network allowed [defaults, go] is used (fixing redirects from proxy.golang.org).
Changes:
- Add
storage.googleapis.comto thegoentry inecosystem_domains.json. - Update the Go ecosystem expansion test to assert
storage.googleapis.comis included.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/workflow/data/ecosystem_domains.json | Expands Go ecosystem allowlist to include the CDN host used for module archive downloads. |
| pkg/workflow/ecosystem_domains_test.go | Adds a test expectation ensuring storage.googleapis.com is present when expanding the Go ecosystem. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
152
to
159
| expectedDomains := []string{ | ||
| "go.dev", | ||
| "golang.org", | ||
| "proxy.golang.org", | ||
| "sum.golang.org", | ||
| "pkg.go.dev", | ||
| "storage.googleapis.com", | ||
| } |
There was a problem hiding this comment.
The embedded go ecosystem list in ecosystem_domains.json includes goproxy.io, but this test doesn’t assert it. That means the test could pass even if goproxy.io is accidentally removed from the go allowlist. Add goproxy.io to expectedDomains here to keep the test aligned with the source allowlist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14216by addingstorage.googleapis.comto the go ecosystem network allowlist.Problem
When workflows use
network allowed [defaults, go], the AWF firewall allowsproxy.golang.orgbut blocks redirects tostorage.googleapis.com(the CDN backing store for Go modules), causing 403 Forbidden errors duringgo build,go test, etc.Changes Made
pkg/workflow/data/ecosystem_domains.json: Addedstorage.googleapis.comto thegoecosystem identifierpkg/workflow/ecosystem_domains_test.go: Added test assertion to verifystorage.googleapis.comis included in the go ecosystemImpact
Workflows using the
goecosystem identifier will now be able to download Go modules successfully without manually addingstorage.googleapis.comto their allowed domains list.Testing
The ecosystem test has been updated to verify that
storage.googleapis.comis properly included. The test will pass once the changes are deployed and the firewall configuration is updated.✨ Created by Claude via
/cloclo🎭