Conversation
…footer config The add_comment.cjs file was using a hardcoded footer instead of the generateFooterWithMessages function, which prevented custom footer configurations from being applied. This change: - Replaces hardcoded footer with generateFooterWithMessages call - Adds workflow source and triggering context to footer generation - Updates test expectations to match new footer format Fixes the issue where workflows with custom footer messages in the messages.footer configuration were not being applied to comments. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
add_comment.cjssafe output handler was using a hardcoded footer instead of thegenerateFooterWithMessagesfunction. This prevented custom footer configurations specified in workflow frontmatter from being applied to comments.Investigation (from live data)
Workflow Run Analysis: #22037921224
add_comment.cjsused hardcoded footer:> AI generated by [workflow](url)Expected Footer (from workflow config):
Changes Made
actions/setup/js/add_comment.cjs> AI generated by [workflow](url)generateFooterWithMessages()to respect custom footer configurationgetMissingInfoSections()call (already included ingenerateFooterWithMessages)actions/setup/js/add_comment.test.cjsgenerateFooterWithMessagesExpected Improvements
create_issueandadd_commentfooter behaviorgenerateFooterWithMessagesValidation
All JavaScript files formatted successfully with
make fmt-cjs.References
Log analysis:
/tmp/gh-aw/aw-mcp/logs/run-22037921224/Run ID investigated: 22037921224
Triggering issue: [smoke-temporary-id] Sub-Issue 2: Test Different ID Length #15936 (pelikhan's investigation request)
Fixes [smoke-temporary-id] Sub-Issue 2: Test Different ID Length #15936