Clean-up temporary ID pattern and add deferral logic to update-project#16098
Merged
Clean-up temporary ID pattern and add deferral logic to update-project#16098
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the safe-outputs tool schemas and tests to use a consistent temporary ID length (3–8 chars) and adds retry-friendly deferral behavior to update_project when it references unresolved temporary issue IDs.
Changes:
- Relax temporary ID regex patterns from
{4,8}to{3,8}across tool schemas and related tests. - Add
update_projecthandler deferral whencontent_number/issue/pull_requestis an unresolved temporary ID. - Add unit test coverage for the new
update_projectdeferral behavior.
Reviewed changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/js/safe_outputs_tools.json | Updates schema patterns for temporary IDs (3–8) for multiple tools. |
| actions/setup/js/safe_outputs_tools.json | Mirrors schema pattern updates for the JS tool definitions. |
| actions/setup/js/update_project.cjs | Defers update_project when the referenced issue/PR temp ID is not yet resolved. |
| actions/setup/js/update_project.test.cjs | Adds a test asserting deferral behavior and no GraphQL call on unresolved temp IDs. |
| actions/setup/js/create_issue_new_arch.test.cjs | Updates temporary ID regex expectation to 3–8 chars. |
| actions/setup/js/create_issue.test.cjs | Updates temporary ID regex expectation to 3–8 chars. |
Comments suppressed due to low confidence (1)
pkg/workflow/js/safe_outputs_tools.json:892
temporary_idfor draft issues currently disallows a leading#, but the update_project handler accepts#aw_...and normalizes it by stripping the hash. To avoid rejecting inputs the handler can process (and to stay consistent withactions/setup/js/safe_outputs_tools.json), consider allowing an optional leading#in this pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 53 out of 53 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Copilot AI
added a commit
that referenced
this pull request
Feb 16, 2026
…y_id patterns
Align pkg/workflow/js/safe_outputs_tools.json schema with actions/setup/js/safe_outputs_tools.json
and the update_project handler implementation which already accepts and strips # prefix.
Changes:
- Update draft_issue_id pattern from ^aw_[A-Za-z0-9]{3,8}$ to ^#?aw_[A-Za-z0-9]{3,8}$
- Update temporary_id pattern from ^aw_[A-Za-z0-9]{3,8}$ to ^#?aw_[A-Za-z0-9]{3,8}$
- Update descriptions to reflect optional # prefix support
Fixes schema validation failures for inputs like #aw_abc123 that work at runtime.
Addresses: #16098 (comment)
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…# prefix support (#16104)
Contributor
Author
|
@copilot recompile workflows |
Contributor
This was referenced Feb 16, 2026
davidahmann
pushed a commit
to davidahmann/gh-aw
that referenced
this pull request
Feb 16, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_projectby deferring updates when a referenced temporary ID cannot be resolved (yet).