[code-simplifier] Simplify assign-to-agent JavaScript code

[github-actions]

Code Simplification - 2026-02-17

This PR simplifies recently modified code to improve clarity, consistency, and maintainability while preserving all functionality.

Files Simplified

• actions/setup/js/assign_to_agent.cjs - Replaced string concatenation with array-based template building
• actions/setup/js/assign_agent_helpers.cjs - Applied ES6 property shorthand for object literals

Improvements Made

1. Enhanced Clarity

   • Replaced incremental string concatenation (content += ...) with array-based approach (parts.push() + join())
   • Makes the template building logic more explicit and easier to understand
   • Eliminates mutable variable pattern in favor of declarative approach

2. Applied Modern JavaScript Standards

   • Used ES6 property shorthand: assignableId instead of assignableId: assignableId
   • Follows project convention for concise object literal syntax
   • Reduces redundancy without sacrificing clarity

Changes Based On

Recent changes from:

• Add model, custom_agent, and custom_instructions parameters to assign-to-agent (frontmatter configuration) #16386 - Add model, custom_agent, and custom_instructions parameters to assign-to-agent (frontmatter configuration)
• Commit 99cd395 - Merged PR Add model, custom_agent, and custom_instructions parameters to assign-to-agent (frontmatter configuration) #16386

Testing

Due to environment network restrictions preventing Go toolchain download, automated tests could not be executed. However:

• ✅ JavaScript formatting validated (make fmt-cjs and make lint-cjs passed)
• ✅ Manual code review confirms no functional changes
• ✅ Changes are purely syntactic improvements
• ✅ String concatenation logic produces identical output using array join approach
• ✅ Property shorthand is semantically equivalent to explicit property assignment

Review Focus

Please verify:

• Functionality is preserved (string template output identical)
• Simplifications improve code quality
• Changes align with JavaScript best practices
• No unintended side effects

Code Quality Improvements

Before (String concatenation):

let content = "";
if (item.issue_number) {
  content += `**Issue:** #\$\{item.issue_number}\n`;
}
content += `**Agent:** \$\{item.agent || previewDefaultAgent}\n`;
// ... more concatenations
return content;

After (Array join):

const parts = [];
if (item.issue_number) {
  parts.push(`**Issue:** #\$\{item.issue_number}`);
}
parts.push(`**Agent:** \$\{item.agent || previewDefaultAgent}`);
// ... more pushes
return parts.join("\n") + "\n\n";

Before (Redundant property):

variables = {
  assignableId: assignableId,
  actorIds,
};

After (Property shorthand):

variables = {
  assignableId,
  actorIds,
};

---

Automated by Code Simplifier Agent - analyzing code from the last 24 hours

AI generated by Code Simplifier

• expires on Feb 18, 2026, 7:03 PM UTC

[Copilot]

Pull request overview

This PR simplifies recently modified JavaScript code related to agent assignment functionality by applying modern JavaScript patterns without changing any functionality. The changes follow the automated code simplifier process to improve code maintainability.

Changes:

• Converted string concatenation to array-based template building in agent assignment preview rendering
• Applied ES6 property shorthand in GraphQL mutation variable construction

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
actions/setup/js/assign_to_agent.cjs	Replaced incremental string concatenation with array-based approach (parts.push() + join()) for staged mode preview rendering
actions/setup/js/assign_agent_helpers.cjs	Applied ES6 property shorthand (assignableId instead of assignableId: assignableId) in two GraphQL mutation variable objects

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.