chore: add Experimental Editor link to docs header + legal footer#16448
chore: add Experimental Editor link to docs header + legal footer#16448
Conversation
Add italic+dashed-border "Experimental Editor" link to header nav, and replace single Terms link with Terms · Privacy · Security using official GitHub legal URLs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR enhances the documentation site's navigation and footer by adding an experimental editor link and updating legal footer links to official GitHub policy pages.
Changes:
- Adds "Experimental Editor" navigation link with italic styling and dashed border to indicate experimental status
- Replaces single GitHub Next Terms of Service link with three official GitHub legal links (Terms, Privacy, Security)
- Adds styling for legal separator dots with theme-aware colors
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/src/components/CustomHeader.astro | Adds experimental editor link to navigation bar with italic+dashed styling |
| docs/src/components/CustomFooter.astro | Replaces single Terms link with three official GitHub legal links and adds separator styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .experimental-link { | ||
| font-style: italic; | ||
| border: 1px dashed rgba(110, 118, 129, 0.4); | ||
| } |
There was a problem hiding this comment.
The experimental-link border style may not be visible enough in light theme. The border color rgba(110, 118, 129, 0.4) is designed for dark backgrounds. Consider adding a light theme variant using :global([data-theme='light']) .experimental-link with a darker border color (e.g., rgba(110, 118, 129, 0.6) or a similar color to what's used elsewhere in the codebase for light theme borders).
| } | |
| } | |
| :global([data-theme='light']) .experimental-link { | |
| border-color: rgba(110, 118, 129, 0.6); | |
| } |
|
|
||
| .experimental-link { | ||
| font-style: italic; | ||
| border: 1px dashed rgba(110, 118, 129, 0.4); |
There was a problem hiding this comment.
The 1px dashed border added to .experimental-link will make this link element 2px taller than other header links (1px top + 1px bottom). Consider adjusting the padding to compensate, for example by reducing top/bottom padding to maintain consistent alignment with other header links. This could be achieved by overriding the padding in .experimental-link to something like 'padding: calc(0.25rem - 1px) 0.75rem;' to account for the border.
| border: 1px dashed rgba(110, 118, 129, 0.4); | |
| border: 1px dashed rgba(110, 118, 129, 0.4); | |
| padding: calc(0.25rem - 1px) 0.75rem; |
Summary
/editor/Test plan
make build-docs— Astro build succeeds (pre-existing broken internal links fromstarlight-links-validatorare unrelated)🤖 Generated with Claude Code