Skip to content

Fix engine registry tests after copilot-sdk removal#16531

Merged
pelikhan merged 2 commits intocopilot/remove-copilot-sdk-agent-enginefrom
copilot/fix-tests-9331f35c-c060-4538-a771-751fa5fcd8b0
Feb 18, 2026
Merged

Fix engine registry tests after copilot-sdk removal#16531
pelikhan merged 2 commits intocopilot/remove-copilot-sdk-agent-enginefrom
copilot/fix-tests-9331f35c-c060-4538-a771-751fa5fcd8b0

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

Tests were failing because they expected 5 built-in engines, but the copilot-sdk engine was removed in the previous PR, leaving only 4 (claude, codex, copilot, custom).

Changes

  • Updated TestEngineRegistry to expect 4 engines instead of 5
  • Updated TestEngineRegistryCustomEngine to expect 5 engines after registration instead of 6
-	if len(supportedEngines) != 5 {
-		t.Errorf("Expected 5 supported engines, got %d", len(supportedEngines))
+	if len(supportedEngines) != 4 {
+		t.Errorf("Expected 4 supported engines, got %d", len(supportedEngines))

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha runs/20260218-055540-13680/test-2350562482/.github/workflows --write /node_modules/.bin/node --ignore-path .prettierignore x_amd64/vet node 6209�� --write 6209674/b368/_testmain.go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/link --ignore-path ../../../.prettirev-parse x_amd64/vet /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/link (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha -unreachable=false /tmp/go-build1798694055/b073/vet.cfg bin/sh (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha ingutil.test (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha github.com/securego/gosec/v2/cmd/gosec (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha /tmp/TestHashConsistency_GoAndJavaScript1810418115/001/test-compnonexistent/repo 64/pkg/tool/linu-buildtags /usr/bin/git ZEU4uWQzZ --local 64/pkg/tool/linu--show-toplevel git rese�� HEAD .github/workflows/test.md /usr/bin/git om/goccy/go-yamlgit .cfg .cfg git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha /tmp/go-build1798694055/b273/_pkg_.a -trimpath 0/x64/bin/sh ree/children.go ree/enumerator.g/tmp/js-hash-test-2651215762/test-hash.js -lang=go1.16 /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linu-buildtags -uns�� *.json' '!../../../pkg/workflow/js/**/*.json' ---errorsas /tmp/go-build1798694055/b004/vet.cfg 64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports -importcfg 64/pkg/tool/linuREDACTED (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha ithub/workflows/bot-detection.md -trimpath /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/compile -p golang.org/x/cryrev-parse -lang=go1.24 /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/compile -o /tmp/go-build2046209674/b389/_pkg_.a -trimpath /usr/bin/git -p github.com/githurev-parse -lang=go1.25 git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha -m om/owner/repo.git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -D GOAMD64_v1 -o /tmp/go-build2046209674/b354/salsa20_amd64.o /home/REDACTED/go/pkg/mod/golang.org/x/crypto@v0.48.0/salsa20/salsa/salsa20_amd64.s (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -c=4 -nolocalimports -importcfg /tmp/go-build2046209674/b382/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/envutil/envutil.go /home/REDACTED/work/gh-aw/gh-aw/pkg/envutil/envutil_test.go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha h ../../../.pret.prettierignore /huh@v0.8.0/clamp.go /node (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha 6209674/b380/_pkg_.a (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha vaScript1810418115/001/test-compnonexistent/repo go /usr/bin/sh % (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 8694055/b158/vet.cfg x_amd64/compile --log-target journal-or-kmsg (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 8694055/b119/vet.cfg x_amd64/link project requiregit (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 8694055/b121/vet.cfg x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 8694055/b168/vet.cfg tions/setup/node_modules/.bin/sh --log-target journal-or-kmsg (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 8694055/b170/vet.cfg de_modules/.bin/sh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path -c=4 -nolocalimports -importcfg /tmp/go-build2046209674/b350/importcfg -pack /home/REDACTED/go/pkg/mod/golang.org/x/crypto@v0.48.0/curve25519/curve25519.go x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 l/format (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 thub.com> (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha pkg/mod/github.com/pmezard/go-di-c=4 (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha NTI6/M28IOFimkK0go1.25.0 pkg/mod/github.c-c=4 64/bin/sh (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo /node (http block)
  • https://api.github.com/repos/owner/repo/contents/file.md
    • Triggering command: /tmp/go-build2046209674/b368/cli.test /tmp/go-build2046209674/b368/cli.test -test.testlogfile=/tmp/go-build2046209674/b368/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true ame (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -c=4 -nolocalimports -importcfg /tmp/go-build2046209674/b345/importcfg -pack /home/REDACTED/go/pkg/mod/github.com/spf13/pflag@v1.0.10/bool.go /home/REDACTED/go/pkg/mod/github.com/spf13/pflag@v1.0.10/bool_func.go (http block)
  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/22128264202/job/63962835060#step:9:1

Fix tests


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing unit tests in codebase Fix engine registry tests after copilot-sdk removal Feb 18, 2026
Copilot AI requested a review from pelikhan February 18, 2026 05:58
@pelikhan pelikhan marked this pull request as ready for review February 18, 2026 05:59
Copilot AI review requested due to automatic review settings February 18, 2026 05:59
@pelikhan pelikhan merged commit 240ffac into copilot/remove-copilot-sdk-agent-engine Feb 18, 2026
@pelikhan pelikhan deleted the copilot/fix-tests-9331f35c-c060-4538-a771-751fa5fcd8b0 branch February 18, 2026 05:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates workflow engine registry tests to reflect removal of the copilot-sdk engine, reducing the number of built-in engines from 5 to 4.

Changes:

  • Adjust TestEngineRegistry to expect 4 built-in engines.
  • Adjust TestEngineRegistryCustomEngine to expect 5 engines after registering one additional custom engine.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments