Fix validate_errors.cjs to handle missing logs folder gracefully#1794
Merged
Fix validate_errors.cjs to handle missing logs folder gracefully#1794
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Validate existence of logs folder in agent logs
Fix validate_errors.cjs to handle missing logs folder gracefully
Oct 16, 2025
Contributor
|
Agentic Changeset Generator triggered by this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
validate_errors.cjsscript was throwing an error when the logs folder doesn't exist, causing workflow failures:This occurred because:
GITHUB_AW_AGENT_OUTPUTto/tmp/gh-aw/.copilot/logs/(a directory)if: always()Solution
Modified the error handling in
validate_errors.cjsto gracefully handle missing log paths by logging an informational message and returning early, rather than throwing an error:Before:
After:
This approach:
parse_copilot_log.cjs, which handles the same scenario gracefullyTesting
validate_errors.test.cjs)make agent-finishvalidation completed successfullyFixes the error reported in the issue where the validation step was failing due to a missing logs folder.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.