Add GH_AW_GITHUB_TOKEN secret check for GitHub remote mode in mcp inspect#1807
Merged
Add GH_AW_GITHUB_TOKEN secret check for GitHub remote mode in mcp inspect#1807
Conversation
…pect Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…equirement Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add check for GH_AW_GITHUB_TOKEN secret in remote mode
Add GH_AW_GITHUB_TOKEN secret check for GitHub remote mode in mcp inspect
Oct 16, 2025
pelikhan
approved these changes
Oct 16, 2025
Contributor
|
Agentic Changeset Generator triggered by this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
gh aw mcp inspectto inspect workflows that configure the GitHub MCP server in remote mode, the command did not check for the requiredGH_AW_GITHUB_TOKENsecret. This meant users would only discover the missing secret when attempting to connect to the remote GitHub MCP server, resulting in a generic 401 Unauthorized error without clear guidance.Solution
Modified the
validateServerSecretsfunction inpkg/cli/mcp_inspect_mcp.goto automatically detect when the GitHub tool is configured in remote mode and addGH_AW_GITHUB_TOKENto the list of required secrets to check.The implementation:
config.Name == "github"andconfig.Type == "http"GH_AW_GITHUB_TOKENto required secrets when GitHub is in remote modegithub-token, it checks for that token insteadGITHUB_PERSONAL_ACCESS_TOKENExample Usage
Testing
Added comprehensive test cases covering:
GH_AW_GITHUB_TOKENGH_AW_GITHUB_TOKEN)All existing tests pass, and the implementation follows existing patterns in the codebase.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.