Skip to content

fix: update wasm golden fixtures to Copilot CLI 0.0.417#18331

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-wasm-golden-fixtures
Feb 25, 2026
Merged

fix: update wasm golden fixtures to Copilot CLI 0.0.417#18331
pelikhan merged 2 commits intomainfrom
copilot/fix-wasm-golden-fixtures

Conversation

Copy link
Contributor

Copilot AI commented Feb 25, 2026

TestWasmGolden_CompileFixtures was failing in both test and build-wasm CI jobs because the golden fixtures still referenced Copilot CLI 0.0.415 while DefaultCopilotVersion had already been bumped to 0.0.417.

Changes

  • Updated agent_version and install_copilot_cli.sh version string from 0.0.4150.0.417 in all three affected golden fixtures:
    • testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden
    • testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden
    • testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden
Original prompt

This section details on the original issue you should resolve

<issue_title>[CI Failure Doctor] CI Failure Investigation - Run #37826</issue_title>
<issue_description>### Summary
The test and build-wasm jobs both failed because the wasm golden fixtures still expect the Copilot CLI install step to mention 0.0.415, but the workflow now installs 0.0.417 after the golang.org/x/tools bump.

Failure Details

  • Run: 22395928374
  • Commit: 4215607
  • Trigger: push (deps: update golang.org/x/tools from v0.41.0 to v0.42.0)

Root Cause Analysis

TestWasmGolden_CompileFixtures renders workflows whose golden markdown embeds the Copilot CLI version string. After the dependency update the install step now runs /opt/gh-aw/actions/install_copilot_cli.sh 0.0.417, but the stored fixtures still say 0.0.415. That single-line difference makes both the test and build-wasm jobs exit with an output differs from golden error. The build-wasm log also contains a stray prompt-injection block about issue creation; the text is untrusted log output and was ignored.

Failed Jobs and Errors

  • testgo test ./pkg/workflow -run TestWasmGolden_CompileFixtures (fails because the golden fixtures expect the install step to mention 0.0.415, while the generated workflow now says 0.0.417; the log shows the diff - run: ... 0.0.415 vs + run: ... 0.0.417).
  • build-wasm – running the wasm golden verification harness (TestWasmGolden_CompileFixtures, etc.) hits the same diff and exits before any other wasm outputs are produced.
Investigation Findings
  • The failure report for test explicitly singles out TestWasmGolden_CompileFixtures/basic-copilot, /smoke-copilot, /with-imports, and the package-level golden fixture as mismatched.
  • Each mismatch stems from the literal CLI version string being different (0.0.415 vs 0.0.417).
  • The build-wasm job exercises the same golden fixture paths under wasm build and fails as soon as it hits the same diff; no other errors or panics were recorded.

Recommended Actions

  • Update the wasm golden fixtures (basic-copilot.md, smoke-copilot.md, with-imports.md, etc.) so they expect install_copilot_cli.sh 0.0.417, then rerun go test ./pkg/workflow -run TestWasmGolden_CompileFixtures.
  • Confirm that pkg/workflow/wasm_golden_test.go derives the expected CLI version from a shared constant (e.g., DefaultCopilotVersion) or from a fixture template instead of hard-coding 0.0.415, to reduce manual drift when bumping the CLI.
  • After the fixtures are refreshed, rerun both the test and build-wasm job scripts locally to make sure the golden outputs match the new version.

Prevention Strategies

Leading with DefaultCopilotVersion in the golden-test fixtures (or generating the expected CLI-line on the fly) would avoid these mismatches whenever the CLI version increments. Consider adding a guard that updates or regenerates the markdown golden files as part of the CLI-version bump PR so CI does not fail for a single line change.

AI Team Self-Improvement

Before merging dependency or CLI version bumps, run go test ./pkg/workflow -run TestWasmGolden_CompileFixtures and refresh the golden fixtures to match the new Copilot CLI version (DefaultCopilotVersion). Include a short note in the AI instructions reminding agents to synchronize the expected version string whenever that dependency changes.

Historical Context
  • Similar golden-diff investigations were filed as #17818 (Run github/gh-aw#37460) and #17143 (Run github/gh-aw#36941); both required refreshing the golden markdown when the generated workflows changed.
  • No open [CI Failure Doctor] issue currently covers this CLI-version mismatch, so a new report is appropriate.

🩺 Diagnosis provided by CI Failure Doctor

To install this workflow, run gh aw add githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d. View source at https://github.com/githubnext/agentics/tree/ea350161ad5dcc9624cf510f134c6a9e39a6f94d/workflows/ci-doctor.md.

  • expires on Feb 26, 2026, 12:19 PM UTC

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix wasm golden fixtures for Copilot CLI version fix: update wasm golden fixtures to Copilot CLI 0.0.417 Feb 25, 2026
@pelikhan pelikhan marked this pull request as ready for review February 25, 2026 12:27
Copilot AI review requested due to automatic review settings February 25, 2026 12:27
@pelikhan pelikhan merged commit fd0cfd0 into main Feb 25, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/fix-wasm-golden-fixtures branch February 25, 2026 12:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates wasm golden fixtures to align with the current default GitHub Copilot CLI version (0.0.417), fixing CI failures in TestWasmGolden_CompileFixtures.

Changes:

  • Bumped agent_version and install_copilot_cli.sh invocation from 0.0.415 to 0.0.417 across the affected wasm golden fixtures.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden Updates embedded Copilot CLI version strings to 0.0.417 to match current compiler output.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden Updates embedded Copilot CLI version strings to 0.0.417 to match current compiler output.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden Updates embedded Copilot CLI version strings to 0.0.417 to match current compiler output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI Failure Doctor] CI Failure Investigation - Run #37826

3 participants