Conversation
…SON config Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
payloadSizeThreshold field
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
|
Smoke Test Results — §22521531657
Overall: CC
|
There was a problem hiding this comment.
This PR cleanly fixes the MCP gateway config validation failure. The root cause (emitting undeclared fields payloadSizeThreshold/payloadPathPrefix against a schema with additionalProperties: false) is correctly addressed by removing them from the rendered JSON. The forward-looking schema update in both schema files documents intent for future gateway versions. All 162 lock files recompiled correctly.
📰 BREAKING: Report filed by Smoke Copilot
| if options.GatewayConfig.PayloadSizeThreshold > 0 { | ||
| fmt.Fprintf(&configBuilder, ",\n \"payloadSizeThreshold\": %d", options.GatewayConfig.PayloadSizeThreshold) | ||
| } | ||
| configBuilder.WriteString("\n") |
There was a problem hiding this comment.
Good fix — removing payloadSizeThreshold and payloadPathPrefix from the inline JSON config avoids schema validation failures with gateway container v0.1.6. These values are still passed via env vars so gateway behavior is preserved. Clean approach!
| "minLength": 1, | ||
| "pattern": "^(/|[A-Za-z]:\\\\)" | ||
| }, | ||
| "payloadSizeThreshold": { |
There was a problem hiding this comment.
Adding payloadSizeThreshold and payloadPathPrefix to the schema is a great forward-looking change — it documents intent and will allow future gateway versions to accept these fields from JSON config rather than only env vars. 👍
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
There was a problem hiding this comment.
Pull request overview
Fixes MCP gateway startup failures by ensuring the rendered gateway JSON config does not include fields rejected by the gateway container’s strict schema validation.
Changes:
- Stop emitting
payloadSizeThreshold/payloadPathPrefixin the rendered gateway JSON config (they remain passed via env vars). - Extend the MCP gateway JSON schema (both
docs/publicandpkg/workflow) to includepayloadSizeThresholdandpayloadPathPrefix. - Update rendered-output expectations and recompile workflow lockfiles to match the schema-compliant gateway JSON block.
Reviewed changes
Copilot reviewed 166 out of 166 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/mcp_renderer.go | Removes payloadPathPrefix / payloadSizeThreshold from the emitted gateway JSON block to avoid schema validation failures. |
| pkg/workflow/codex_engine_test.go | Updates expected rendered output to match the new gateway JSON rendering (no trailing comma / no removed fields). |
| pkg/workflow/schemas/mcp-gateway-config.schema.json | Adds payloadSizeThreshold / payloadPathPrefix to gatewayConfig so schema reflects intended/possible config fields. |
| docs/public/schemas/mcp-gateway-config.schema.json | Mirrors the schema additions for published documentation consumers. |
| .github/workflows/*.lock.yml | Regenerated lockfiles to remove the offending gateway JSON fields and keep compiled workflows consistent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude
The
Safe Output Health Monitorworkflow was consistently failing at "Start MCP Gateway" because the gateway container (v0.1.6) validates its JSON config against the schema at tagv0.41.1, which hasadditionalProperties: falseongatewayConfig— but the compiled config was emittingpayloadSizeThreshold(and conditionallypayloadPathPrefix), neither of which existed in that schema.Changes
pkg/workflow/mcp_renderer.go: Remove emission ofpayloadSizeThresholdandpayloadPathPrefixfrom the gateway JSON config block. Both values are already forwarded to the container via env vars (MCP_GATEWAY_PAYLOAD_SIZE_THRESHOLD,MCP_GATEWAY_PAYLOAD_PATH_PREFIX), so gateway behavior is unchanged.Both schema files (
docs/public/schemas/andpkg/workflow/schemas/): AddpayloadSizeThresholdandpayloadPathPrefixtogatewayConfigso the schema reflects intent and future gateway versions can validate these fields from config rather than only env vars.pkg/workflow/codex_engine_test.go: Update expected rendered output to match.All 162
.lock.ymlfiles recompiled to remove the offending field.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw(http block)/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw ota=5% yHigh=170M x_amd64/vet mcp-�� js/**/*.json' --ignore-path ../../../.prettierignore --local 64/pkg/tool/linux_amd64/vet user.email(http block)/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw ota=5% yHigh=170M x_amd64/vet conf�� js/**/*.json' --ignore-path ../../../.prettierignore --local 64/pkg/tool/linux_amd64/vet user.email(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/a70c5eada06553e3510ac27f2c3bda9d3705bccb/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/a70c5eada06553e3510ac27f2c3bda9d3705bccb --jq .object.sha ath ../../../.pr--log-target(http block)https://api.github.com/repos/githubnext/agentics/git/ref/tags//usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
✨ PR Review Safe Output Test - Run 22521531658
Changeset
Warning
The following domains were blocked by the firewall during workflow execution:
codeload.github.comgithub.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.