fix: remove unused git helper functions causing lint-go CI failure#19189
Merged
fix: remove unused git helper functions causing lint-go CI failure#19189
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI failure by removing unused git helper functions
fix: remove unused git helper functions causing lint-go CI failure
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes dead git helper functions from pkg/cli/git.go to resolve golangci-lint failures from the unused analyzer without changing runtime behavior.
Changes:
- Deleted unused helpers:
pullFromRemote,pushToRemote, andcommitAndPushChanges. - Deleted now-orphaned helpers:
hasChangesToCommitandhasRemote. - Kept
stageAllChanges(still used by PR creation helpers).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint'sunusedcheck was blocking CI because five dead functions inpkg/cli/git.gohad no callers.Changes
pullFromRemote,pushToRemote, andcommitAndPushChanges— flagged directly by linthasChangesToCommitandhasRemote— became orphaned oncecommitAndPushChanges(their sole caller) was deletedstageAllChanges— still actively used inpkg/cli/pr_helpers.goOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.