Delete zombie test files from pkg/workflow/ (batch 1 of 2) by Copilot · Pull Request #19334 · github/gh-aw

Copilot · 2026-03-03T04:31:46Z

31 test files across the repo were left behind after the JS scripts migrated from embedded/inlined to runtime-loaded via require(). All functions in these files unconditionally call t.Skip() — zero coverage, pure noise.

Changes

Deleted 13 all-skipped files from pkg/workflow/: codex_test.go, comment_env_vars_conditional_test.go, compiler_mcp_test.go, compiler_reactions_test.go, create_agent_session_integration_test.go, create_issue_assignees_test.go, create_issue_subissue_test.go, create_pr_review_comment_test.go, create_pull_request_allow_empty_test.go, create_pull_request_reviewers_test.go, github_context_test.go, log_parser_docker_format_test.go, log_parser_new_format_file_test.go
Partially edited branch_normalize_integration_test.go: 2 of 3 functions contain real tests; only the skipped TestUploadAssetsJobHasInlinedNormalization was removed

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/graphql
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git -json GO111MODULE x_amd64/compile git (http block)
- Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name /usr/bin/git md GO111MODULE 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git se 6820149/b045/vetrev-parse .cfg git (http block)
- Triggering command: /usr/bin/gh gh repo view owner/repo patc�� --show-toplevel x_amd64/compile /usr/bin/git -json GO111MODULE ache/go/1.25.0/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git 3730-27619/test-git 6820149/b057/vetrev-parse .cfg git (http block)
https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
- Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha --show-toplevel whrn9NjtCOgd (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha te 'scripts/**/*.js' --ignore-path .prettierignore --log-level=e!../../../pkg/workflow/js/**/*.jgit st/dist/workers/forks.js tnet/tools/sh -M ode-branch de/node/bin/git /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /tmp�� te '../../../**/*.json' '!../../../pkg/workflow/js/**/*.json' --ignore-path ../../../.prettieriggit git /opt/hostedtoolcache/uv/0.10.7/x86_64/node -b main p/bin/git node (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v3
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha -unreachable=false /tmp/go-build2466820149/b005/vet.cfg 6820149/b350/vet.cfg GOSUMDB GOWORK 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -uns�� -unreachable=false /tmp/go-build2466820149/b208/vet.cfg ache/node/24.13.1/x64/bin/node -json GO111MODULE 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha 8860427/b081/vet.cfg --quiet 64/bin/node -m Initial commit ache/uv/0.10.7/x--show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet 1/x6�� HEAD 5q1vTj7IRmGm ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -u origin 1d2320fe0412d1f9--show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v5
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE HC/wPHmRHH07drGotDxh6_4/9rUbv3kNremote.origin.url env 1289311031/custom/workflows GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu-buildtags (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha .github/workflows/test.md go /usr/bin/git -json GO111MODULE x_amd64/vet git conf�� user.name Test User /opt/hostedtoolcache/node/24.13.1/x64/bin/node -json GO111MODULE x_amd64/vet node (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git -json .cfg 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git -json .cfg aw.test git (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v6
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha runs/20260303-043730-27619/test-3672644730 --jq /usr/bin/git npx prettier --cgit GOPROXY 64/bin/go git rev-�� --show-toplevel sh (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha se 6820149/b113/vet.cfg /usr/bin/git -test.timeout=10git -test.run=^Test -test.short=true--show-toplevel git rev-�� --show-toplevel sh /usr/bin/git "prettier" --chegit sh 64/bin/go git (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha --show-toplevel 64/pkg/tool/linu-dwarf=false /usr/bin/git hub/workflows .cfg 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linu/tmp/go-build2466820149/b436/_testmain.go /usr/bin/git -json GO111MODULE x_amd64/link git (http block)
https://api.github.com/repos/actions/github-script/git/ref/tags/v8
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha HU_C/zdmZ35McVtqGOSUMDB GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE 3810437/b409/imp/tmp/go-build2466820149/b164/vet.cfg /opt�� che/go-build/82/8242caa57cd5fccfGOINSECURE --check 64/bin/go --ignore-path .prettierignore 64/bin/go /opt/hostedtoolc-buildtags (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha "prettier" --check '**/*.cjs' '*GOINSECURE ache/go/1.25.0/x64/src/internal/GOMOD 64/bin/go GOSUMDB GOWORK 64/bin/go /opt/hostedtoolc/tmp/go-build2466820149/b228/vet.cfg -o /tmp/go-build1693810437/b355/_pkGOINSECURE -trimpath 64/bin/go -d main -lang=go1.25 go (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha pkg/mod/github.com/stretchr/testGOINSECURE pkg/mod/github.com/stretchr/testGOMOD 64/bin/go **/*.json --ignore-path ../../../.pretti-unreachable=false /opt/hostedtoolc/tmp/go-build2466820149/b265/vet.cfg -o /tmp/go-build1693810437/b386/_pkGOINSECURE -trimpath 64/bin/go -p github.com/ayman-test.testlogfile=/tmp/go-build2466820149/b001/testlog.txt -lang=go1.23 go (http block)
https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha s/test.md -tests /usr/bin/git eJ9e/ijupBjS8vUUgit GOPROXY 64/bin/go git -C /home/REDACTED/work/gh-aw/gh-aw rev-parse /usr/bin/gh k/gh-aw/gh-aw/pkgit k/gh-aw/gh-aw/pkrev-parse 64/bin/go gh (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha /tmp/go-build3768860427/b027/vet.cfg git e_modules/.bin/node 86_64/git git k/gh-aw/gh-aw/no--show-toplevel /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet k/gh�� ings.cjs forks.js k/gh-aw/gh-aw/node_modules/.bin/sh -m Initial commit erignore /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha s/test.md -test.v=true 6820149/b419/_pkg_.a -test.timeout=10git -test.run=^Test -test.short=true--show-toplevel git -C /home/REDACTED/work/gh-aw/gh-aw/.github/workflows rev-parse /usr/bin/git "prettier" --chegit sh 64/bin/go git (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha /tmp/go-build3768860427/b030/vet.cfg git k/gh-aw/node_modules/.bin/node 1/x64/lib/node_mgit git 1/x64/bin/git /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet k/gh�� ings.cjs forks.js k/gh-aw/gh-aw/actions/setup/node_modules/.bin/sh -m Initial commit erignore /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq .object.sha archie.md GO111MODULE 6820149/b162/vet.cfg GOINSECURE GOMOD GOMODCACHE /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -uns�� 3730-27619/test-3672644730 /tmp/go-build2466820149/b031/vet.cfg 6820149/b290/vet.cfg GOSUMDB GOWORK 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq .object.sha .cfg git 64/pkg/tool/linux_amd64/vet mport-meta-resolgit the new one k/gh-aw/gh-aw/ac--show-toplevel 64/pkg/tool/linux_amd64/vet .cfg�� 623788/b356/exe/a.out git ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet ranch..feature-bgit yqBXhhOG9qfYd/Amrev-parse de_modules/.bin/--show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
- Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/pkg/tool/linu-nolocalimports GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu/tmp/go-build2466820149/b428/_testmain.go (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
- Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD c8c9be3b 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
- Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE c8c9be3b GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
- Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env /a.out GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE _bPbL0PWHPvRXvLarev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
- Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link env -json GO111MODULE 64/pkg/tool/linu-importcfg GOINSECURE GOMOD GOMODCACHE 7KRlb0f/T36gUPQZXFjOiSQ6baL5 (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
- Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
- Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/workflows
- Triggering command: /usr/bin/gh gh workflow list --json name,state,path npx prettier --cGOSUMDB GOPROXY 64/bin/go GOSUMDB GOWORK run-script/lib/n-bool sh -c "prettier" --che-errorsas sh 64/bin/go tierignore (http block)
- Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 (http block)
- Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/contents/.github%2Fworkflows%2Faudit-workflows.md
- Triggering command: /opt/hostedtoolcache/node/24.13.1/x64/bin/node /opt/hostedtoolcache/node/24.13.1/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/dist/workers/forks.js git _modules/.bin/gi-- /usr/lib/git-cororigin/main pack�� --all-progress-implied (http block)
https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
- Triggering command: /tmp/go-build2466820149/b383/cli.test /tmp/go-build2466820149/b383/cli.test -test.testlogfile=/tmp/go-build2466820149/b383/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE 3810437/b400/imp/tmp/go-build2466820149/b116/vet.cfg /hom�� che/go-build/28/2888c116b4dd41c7GOINSECURE **/*.cjs 64/bin/go **/*.json --ignore-path ../../../.pretti-unreachable=false /opt/hostedtoolc/tmp/go-build2466820149/b263/vet.cfg (http block)
https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuTest User env 976096168/.github/workflows .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha ignore-path ../../../.prettierignore gin/full-mode-branch x_amd64/vet ix --stdout git x_amd64/vet add README.md git x_amd64/vet git git k/node_modules/.prettier x_amd64/vet (http block)
https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
- Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json .cfg x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha ignore-path ../../../.prettierignore gin/full-mode-branch x_amd64/vet ix --stdout it x_amd64/vet add README.md git modules/@npmcli/run-script/lib/node-gyp-bin/sh /home/REDACTED/.lonode git 64/bin/git x_amd64/vet (http block)
https://api.github.com/repos/nonexistent/repo/actions/runs/12345
- Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env hub/workflows .cfg x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link (http block)
https://api.github.com/repos/owner/repo/actions/workflows
- Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOSUMDB GOWORK 64/bin/go node /hom�� --check scripts/**/*.js 64/bin/go .prettierignore (http block)
- Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state /usr/bin/git -json GO111MODULE ache/go/1.25.0/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linutest@example.com /usr/bin/git 3730-27619/test-git 6820149/b068/vetrev-parse .cfg git (http block)
https://api.github.com/repos/owner/repo/contents/file.md
- Triggering command: /tmp/go-build2466820149/b383/cli.test /tmp/go-build2466820149/b383/cli.test -test.testlogfile=/tmp/go-build2466820149/b383/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE 3810437/b400/imp/tmp/go-build2466820149/b116/vet.cfg /hom�� che/go-build/28/2888c116b4dd41c7GOINSECURE **/*.cjs 64/bin/go **/*.json --ignore-path ../../../.pretti-unreachable=false /opt/hostedtoolc/tmp/go-build2466820149/b263/vet.cfg (http block)
https://api.github.com/repos/test-owner/test-repo/actions/secrets
- Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name npx prettier --cGOSUMDB GOPROXY 64/bin/go GOSUMDB GOWORK 64/bin/go sh -c "prettier" --che-errorsas node 64/bin/go tierignore --write 64/bin/go uname (http block)
https://api.github.com/repos/test/repo
- Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch --show-toplevel 64/pkg/tool/linux_amd64/vet 1/x64/bin/npm -json .cfg ache/go/1.25.0/x--show-toplevel 1/x64/bin/npm rev-�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git se 6820149/b071/vetrev-parse ache/go/1.25.0/x--show-toplevel git (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>[plan] Delete zombie test files from pkg/workflow/ (batch 1 of 2)</issue_title>
<issue_description>## Objective

Delete the first batch of permanently-skipped "zombie" test files from pkg/workflow/. These files contain test functions that all unconditionally call t.Skip() with a message like "scripts now use require() pattern to load external files at runtime". They provide zero coverage and should be removed.

Context

Discussion #19223 identified 31 test files across the repo with 93 permanently-skipped functions (1,756 lines of non-functional test code) left behind after an architectural migration where JS scripts moved from embedded/inlined to being loaded at runtime via require() from external files in actions/setup/js/. These files were never re-written or removed.

Files to Delete

Run git rm on these files:
git rm pkg/workflow/branch_normalize_integration_test.go
git rm pkg/workflow/codex_test.go
git rm pkg/workflow/comment_env_vars_conditional_test.go
git rm pkg/workflow/compiler_mcp_test.go
git rm pkg/workflow/compiler_reactions_test.go
git rm pkg/workflow/create_agent_session_integration_test.go
git rm pkg/workflow/create_issue_assignees_test.go
git rm pkg/workflow/create_issue_subissue_test.go
git rm pkg/workflow/create_pr_review_comment_test.go
git rm pkg/workflow/create_pull_request_allow_empty_test.go
git rm pkg/workflow/create_pull_request_reviewers_test.go
git rm pkg/workflow/github_context_test.go
git rm pkg/workflow/log_parser_docker_format_test.go
git rm pkg/workflow/log_parser_new_format_file_test.go
Important: Before deleting each file, verify it only contains permanently-skipped test functions (all functions call t.Skip()). If a file has any non-skipped test functions, do NOT delete it — only remove the skipped functions.

Approach

For each file listed, open it and confirm ALL test functions are skipped with the require() migration message

Run git rm (file) for confirmed all-skip files

Build and run tests to verify nothing breaks

Validation
go build ./...
go vet ./...
make fmt
make test-unit
Acceptance Criteria

All listed files verified as all-skip and deleted

make test-unit passes with no regressions

No non-skipped tests were accidentally removed

Generated by Plan Command for issue #discussion #19223

expires on Mar 4, 2026, 2:57 PM UTC

Comments on the Issue (you are @copilot in this section)

Fixes [plan] Delete zombie test files from pkg/workflow/ (batch 1 of 2) #19241

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Removes permanently skipped (“zombie”) tests left behind after the JS scripts moved from embedded/inlined to runtime require() loading, reducing noise and dead code in pkg/workflow/.

Changes:

Deleted 13 pkg/workflow/*_test.go files whose tests only called t.Skip().
Removed the single skipped test TestUploadAssetsJobHasInlinedNormalization from branch_normalize_integration_test.go while keeping the real tests.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/workflow/codex_test.go	Deleted all-skipped test file.
pkg/workflow/comment_env_vars_conditional_test.go	Deleted all-skipped test file.
pkg/workflow/compiler_mcp_test.go	Deleted all-skipped test file.
pkg/workflow/compiler_reactions_test.go	Deleted all-skipped test file.
pkg/workflow/create_agent_session_integration_test.go	Deleted all-skipped test file.
pkg/workflow/create_issue_assignees_test.go	Deleted all-skipped test file.
pkg/workflow/create_issue_subissue_test.go	Deleted all-skipped test file.
pkg/workflow/create_pr_review_comment_test.go	Deleted all-skipped test file.
pkg/workflow/create_pull_request_allow_empty_test.go	Deleted all-skipped test file.
pkg/workflow/create_pull_request_reviewers_test.go	Deleted all-skipped test file.
pkg/workflow/github_context_test.go	Deleted all-skipped test file.
pkg/workflow/log_parser_docker_format_test.go	Deleted all-skipped test file.
pkg/workflow/log_parser_new_format_file_test.go	Deleted all-skipped test file.
pkg/workflow/branch_normalize_integration_test.go	Removed one permanently skipped test while preserving the remaining real tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Initial plan

c6c6510

Copilot AI assigned Copilot and pelikhan Mar 3, 2026

Copilot started work on behalf of pelikhan March 3, 2026 04:31 View session

Copilot AI and others added 2 commits March 3, 2026 04:38

Update; rm -rf /

9e36c92

chore: delete zombie test files from pkg/workflow/ (batch 1 of 2)

7e31a38

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Delete first batch of zombie test files from pkg/workflow~~ Delete zombie test files from pkg/workflow/ (batch 1 of 2) Mar 3, 2026

Copilot finished work on behalf of pelikhan March 3, 2026 04:41

pelikhan approved these changes Mar 3, 2026

View reviewed changes

pelikhan marked this pull request as ready for review March 3, 2026 04:48

Copilot AI review requested due to automatic review settings March 3, 2026 04:48

Copilot started reviewing on behalf of pelikhan March 3, 2026 04:49 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

pelikhan merged commit e9c50c9 into main Mar 3, 2026
110 checks passed

pelikhan deleted the copilot/delete-zombie-test-files-batch-1 branch March 3, 2026 04:54

github-actions bot mentioned this pull request Mar 3, 2026

Smoke Test: Copilot - 22615013107 #19363

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete zombie test files from pkg/workflow/ (batch 1 of 2)#19334

Delete zombie test files from pkg/workflow/ (batch 1 of 2)#19334
pelikhan merged 3 commits intomainfrom
copilot/delete-zombie-test-files-batch-1

Copilot AI commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

I tried to connect to the following addresses, but was blocked by firewall rules:

Context

Files to Delete

Approach

Validation

Acceptance Criteria

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 3, 2026 •

edited

Loading