Fix buildCustomJobs() to extract 7 silently-dropped job fields by Copilot · Pull Request #19539 · github/gh-aw

Copilot · 2026-03-04T07:58:18Z

Original prompt

This section details on the original issue you should resolve

<issue_title>[plan] Fix buildCustomJobs() to extract silently-dropped job fields</issue_title>
<issue_description>## Objective

Fix buildCustomJobs() in pkg/workflow/compiler_jobs.go to extract the 7 schema-defined job fields that are currently silently dropped at compile time.

Context

From discussion #19383: The buildCustomJobs() function only extracts 8 of the 17 schema-defined job properties. Fields like name, timeout-minutes, env, container, services, and concurrency are accepted by the schema at parse time but silently discarded at compile time — users get no warning.

The Job struct in pkg/workflow/jobs.go already has fields for most of these, and the rendering code in jobs.go already handles them. They just need to be populated during extraction.

Approach

In pkg/workflow/compiler_jobs.go, inside buildCustomJobs() (around line 424), add extraction for each missing field:

name (DisplayName): Extract string from configMap["name"] → job.DisplayName

timeout-minutes: Extract int from configMap["timeout-minutes"] → job.TimeoutMinutes

concurrency: Extract string from configMap["concurrency"] → job.Concurrency

env: Extract map[string]string from configMap["env"] → job.Env

container: Use YAML marshal on configMap["container"] to produce a YAML string → job.Container

services: Use YAML marshal on configMap["services"] to produce a YAML string → job.Services

continue-on-error: Add new ContinueOnError bool field to Job struct, extract bool from configMap["continue-on-error"], add rendering in jobs.go

Files to Modify

pkg/workflow/compiler_jobs.go — add field extraction in buildCustomJobs()

pkg/workflow/jobs.go — add ContinueOnError field to Job struct and rendering logic

Acceptance Criteria

All 7 missing fields are extracted and rendered in compiled YAML output

container and services use YAML marshaling consistent with top-level extraction pattern

continue-on-error: true renders correctly in compiled job YAML

Unit tests added/updated to verify each field is preserved through compilation

Run make agent-finish before committing

Generated by Plan Command for issue #discussion #19383 · ◷

expires on Mar 5, 2026, 10:49 AM UTC

Comments on the Issue (you are @copilot in this section)

Fixes [plan] Fix buildCustomJobs() to extract silently-dropped job fields #19398

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…imeout-minutes, concurrency, env, container, services, continue-on-error)" Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Fixes buildCustomJobs() so several schema-valid job fields are no longer silently dropped during compilation, ensuring they appear in the generated .lock.yml.

Changes:

Extend Job to support continue-on-error and render it in job YAML.
Update buildCustomJobs() to extract and propagate: name, timeout-minutes, concurrency, env, container, services, continue-on-error.
Add unit tests covering extraction/rendering paths via CompileWorkflow() and direct buildCustomJobs().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
pkg/workflow/jobs.go	Adds `ContinueOnError` to `Job` and renders `continue-on-error` in job YAML output.
pkg/workflow/compiler_jobs.go	Extracts previously ignored job fields from custom job configs and populates `Job` accordingly.
pkg/workflow/compiler_jobs_test.go	Adds tests to verify the newly extracted fields are preserved and rendered.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

pkg/workflow/compiler_jobs.go

pkg/workflow/jobs.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

pelikhan · 2026-03-04T09:17:04Z

@copilot fix tests

CI / build-wasm (pull_request)Failing after 53s
CI / test (pull_request)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-03-04T09:24:46Z

@copilot fix tests

CI / build-wasm (pull_request)Failing after 53s
...

Fixed in 51b11ba. The issue was that commit 90a28e7 applied a review suggestion to always render continue-on-error: %t, which emitted continue-on-error: false on every job (since bool defaults to false), breaking the golden tests.

Changed ContinueOnError from bool to *bool — it's only rendered when explicitly set, and now correctly handles both true and false values without polluting jobs that don't set it.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/graphql
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw x_amd64/vet /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git --show-toplevel 64/pkg/tool/linurev-parse /usr/bin/git git (http block)
https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
- Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha te '../../../**/*.json' '!../../../pkg/workflow/js/**/*.json' --ignore-path ../../../.prettieriggit -buildtags /usr/bin/git -errorsas -ifaceassert -nilfunc git rev-�� --show-toplevel -tests /home/REDACTED/work/gh-aw/gh-aw/node_modules/.bin/node (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha it/ref/tags/v7 /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git -bool -buildtags /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git --show-toplevel -tests /usr/bin/git git (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v3
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha */*.ts' '**/*.json' --ignore-path ../../../.prettierignore pull.rebase 86_64/node (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha --show-toplevel /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git rite '../../../*git /tmp/go-build273rev-parse ache/go/1.25.0/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/asm /usr/bin/git -bool -buildtags /home/REDACTED/wor--show-toplevel git (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v5
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha "prettier" --write '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.prettierignore (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --show-toplevel x_amd64/vet /usr/bin/git (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v6
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha te '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pret.prettierignore /tmp/go-build2732162797/b063/vet.cfg nfig/composer/vendor/bin/sh (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha te '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pret.prettierignore /tmp/go-build2732162797/b003/vet.cfg k/gh-aw/gh-aw/actions/setup/node_modules/.bin/node (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha --show-toplevel x_amd64/vet /usr/bin/git h ../../../.pretgit (http block)
https://api.github.com/repos/actions/download-artifact/git/ref/tags/v8
- Triggering command: /usr/bin/gh gh api /repos/actions/download-artifact/git/ref/tags/v8 --jq .object.sha js/**/*.json' --ignore-path ../../../.prettierignore (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/download-artifact/git/ref/tags/v8 --jq .object.sha (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/download-artifact/git/ref/tags/v8 --jq .object.sha ../pkg/workflow/js/**/*.json' ---errorsas om/davecgh/go-spew@v1.1.1/spew/c-ifaceassert ache/go/1.25.0/x64/pkg/tool/linu-nilfunc http.https://gitgit (http block)
https://api.github.com/repos/actions/github-script/git/ref/tags/v8
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha te '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pret.prettierignore -buildtags /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -errorsas -ifaceassert -nilfunc /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet 2162�� rite '../../../**/*.json' '!../../../pkg/workflow/js/**/*.json' --ignore-path ../../../.prettiergit 2162797/b001/_testmain.go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/link (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha te '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pret.prettierignore /tmp/go-build2732162797/b070/vet.cfg k/gh-aw/gh-aw/node_modules/.bin/node (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha --show-toplevel x_amd64/compile /usr/bin/git h ../../../.pretgit (http block)
https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha te '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pret.prettierignore /tmp/go-build2732162797/b124/vet.cfg h -c=4 -nolocalimports -importcfg 2162797/b357/importcfg -uns�� rite '../../../**/*.json' '!../../../pkg/workflow/js/**/*.json' --ignore-path k/gh-aw/gh-aw/pkg/workflow/importable_tools_test.go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha --show-toplevel /bin/sh .cfg cd actions/setupgit (http block)
https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha te '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pret.prettierignore /tmp/go-build2732162797/b053/vet.cfg tnet/tools/sh (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha --show-toplevel /bin/sh /usr/bin/git echo "�� JavaScgit (http block)
https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq .object.sha get --local ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet http.https://gitgit (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq .object.sha ster.patch /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git -unreachable=falgit /tmp/go-build273rev-parse es/.bin/sh git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git te 'scripts/**/*git -buildtags /opt/hostedtoolc--show-toplevel git (http block)
https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v7
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha re --log-level=e!../../../pkg/workflow/js/**/*.json (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha re --log-level=error elds x_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha ignore-path ../../../.prettierignore (http block)
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha xterm-color 64/pkg/tool/linux_amd64/vet /usr/bin/git (http block)
https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
- Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha ignore-path ../../../.prettierignore (http block)
- Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Initial plan

fee7212

Copilot AI assigned Copilot and pelikhan Mar 4, 2026

Copilot started work on behalf of pelikhan March 4, 2026 07:58 View session

Fix buildCustomJobs() to extract silently-dropped job fields (name, t…

82c0a95

…imeout-minutes, concurrency, env, container, services, continue-on-error)" Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix buildCustomJobs to extract silently-dropped job fields~~ Fix buildCustomJobs() to extract 7 silently-dropped job fields Mar 4, 2026

Copilot finished work on behalf of pelikhan March 4, 2026 08:22

pelikhan marked this pull request as ready for review March 4, 2026 08:31

Copilot AI review requested due to automatic review settings March 4, 2026 08:31

Copilot started reviewing on behalf of pelikhan March 4, 2026 08:32 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

pkg/workflow/compiler_jobs.go Show resolved Hide resolved

pkg/workflow/jobs.go Outdated Show resolved Hide resolved

Apply suggestions from code review

90a28e7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of pelikhan March 4, 2026 09:17 View session

Fix ContinueOnError to use *bool to avoid rendering false for all jobs

51b11ba

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan March 4, 2026 09:25

pelikhan approved these changes Mar 4, 2026

View reviewed changes

Merge branch 'main' into copilot/fix-extraction-of-job-fields

49cca0f

pelikhan merged commit 3ee4953 into main Mar 4, 2026
48 checks passed

pelikhan deleted the copilot/fix-extraction-of-job-fields branch March 4, 2026 09:43

github-actions bot mentioned this pull request Mar 4, 2026

Smoke Test: Claude - 22667873177 #19590

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix buildCustomJobs() to extract 7 silently-dropped job fields#19539

Fix buildCustomJobs() to extract 7 silently-dropped job fields#19539
pelikhan merged 5 commits intomainfrom
copilot/fix-extraction-of-job-fields

Copilot AI commented Mar 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

pelikhan commented Mar 4, 2026

Uh oh!

Copilot AI commented Mar 4, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Approach

Files to Modify

Acceptance Criteria

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

pelikhan commented Mar 4, 2026

Uh oh!

Copilot AI commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 4, 2026 •

edited

Loading

Copilot AI commented Mar 4, 2026 •

edited

Loading