fix: add 3 missing action pins entries to resolve TestGetActionPinsSorting failure#20831
Merged
lpcox merged 2 commits intoclaude/configure-smoke-agent-workflowfrom Mar 13, 2026
Conversation
…ailure Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [66992755955] Fix the failing GitHub Actions workflow test
fix: add 3 missing action pins entries to resolve TestGetActionPinsSorting failure
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the embedded action pin registry to fix a CI failure where TestGetActionPinsSorting expected more pins than were present in action_pins.json.
Changes:
- Added missing major-version pin entries for
actions/cache/restore@v4,actions/cache/save@v4, andactions/setup-node@v4to align the JSON data with test expectations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
lpcox
added a commit
that referenced
this pull request
Mar 13, 2026
…repos (#20830) * Initial plan * Plan: Configure smoke-agent workflow with guard policies Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * Configure smoke-agent workflow with guard policies for public repos Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * Use local GitHub MCP container instead of remote mode Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: add 3 missing action pins entries to resolve TestGetActionPinsSorting failure (#20831) * Initial plan * fix: add 3 missing action pins to fix TestGetActionPinsSorting test failure Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * Fix: Generate write-sink with accept:* for repos='public'/'all' When repos is set to "public" or "all", the renderer now creates a write-sink configuration with accept: ["*"] instead of returning nil. This ensures safe outputs work correctly with guard policies. Changes: - Updated deriveSafeOutputsGuardPolicyFromGitHub() to return accept:["*"] - Updated test cases to expect accept:["*"] for repos="all" and repos="public" - Updated documentation and specification to reflect new behavior - Verified smoke-agent workflow compiles with correct guard-policies Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * Update PR title and description Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: add 3 missing action pins to resolve TestGetActionPinsSorting failure (#20837) * Initial plan * fix: add 3 missing action pin entries to resolve TestGetActionPinsSorting failure Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * updated mcpg version * [WIP] [67003058781] Fix the failing GitHub Actions workflow test (#20838) * Initial plan * fix: make TestGetActionPinsSorting resilient to JSON pin count changes Instead of hardcoding the expected pin count (34), the test now dynamically derives the expected count by parsing actionPinsJSON directly. This ensures: - The test always validates that getActionPins() returns all entries from JSON - No manual count updates needed when new pins are added - Resilient to Go test cache issues where stale binaries could cause failures Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * feat: add guard policy smoke test matrix Rename smoke-agent to smoke-agent-public-approved to reflect its guard policy params, and add four new workflows to test different repos scope × min-integrity combinations: - all/none: most permissive, all repos, no integrity requirement - all/merged: most restrictive, all repos, merged content only - scoped/approved: explicit repo patterns (github/gh-aw, github/*), approved - public/none: public repos only, no integrity requirement Each workflow exercises search_repositories, list_issues, and search_code to test guard policy filtering effectiveness, then aggregates results into a safe-outputs PR comment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: upgrade tsconfig lib/target to es2022 to resolve Array.at() TS2550 error (#20849) * Initial plan * fix: upgrade tsconfig target/lib to es2022 to fix TS2550 error with Array.at() Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * Fix two failing JS tests: call_workflow empty allowlist and create_discussion fallback note (#20852) * Initial plan * Initial plan: fix two failing JS tests Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * Fix two failing JS tests: call_workflow empty allowlist and create_discussion fallback note Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Landon Cox <landon.cox@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestGetActionPinsSortingwas asserting 34 pins butaction_pins.jsononly contained 31, causing CI to fail.Changes
pkg/workflow/data/action_pins.json: Added 3 missing v4 pin entries:actions/cache/restore@v4actions/cache/save@v4actions/setup-node@v4These v4 entries were present in
mainalongside their v5 counterparts but were absent in this branch, causing the count mismatch.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.