Skip to content

fix: update tests and golden files for GITHUB_HOST in GitHub MCP server config#20956

Merged
dsyme merged 3 commits intomainfrom
copilot/fix-build-test-failures
Mar 14, 2026
Merged

fix: update tests and golden files for GITHUB_HOST in GitHub MCP server config#20956
dsyme merged 3 commits intomainfrom
copilot/fix-build-test-failures

Conversation

Copy link
Contributor

Copilot AI commented Mar 14, 2026

CI broke after GITHUB_HOST: "${GITHUB_SERVER_URL}" was added to the GitHub MCP server env in mcp_renderer_github.go without updating the corresponding tests and golden files.

Changes

  • codex_engine_test.go: Updated TestCodexEngineRenderMCPConfig/github_tool_with_user_agent to expect GITHUB_HOST in:

    • TOML env/env_vars fields: env = { "GITHUB_HOST" = "$GITHUB_SERVER_URL", ... }
    • JSON MCP gateway config block: "GITHUB_HOST": "$GITHUB_SERVER_URL", before GITHUB_LOCKDOWN_MODE
  • Golden files (basic-copilot, smoke-copilot, with-imports): Regenerated via go test ./pkg/workflow -run='^TestWasmGolden_' -update to reflect GITHUB_HOST in compiled output.

Copilot AI and others added 3 commits March 14, 2026 15:24
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
…MCP server config

Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
Copilot AI linked an issue Mar 14, 2026 that may be closed by this pull request
@dsyme dsyme marked this pull request as ready for review March 14, 2026 17:12
Copilot AI review requested due to automatic review settings March 14, 2026 17:12
@dsyme dsyme merged commit 6ab6bea into main Mar 14, 2026
90 checks passed
@dsyme dsyme deleted the copilot/fix-build-test-failures branch March 14, 2026 17:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates test expectations and regenerated WASM golden outputs to match the recently introduced GITHUB_HOST env var in the GitHub MCP server configuration, fixing CI failures caused by stale fixtures.

Changes:

  • Updated TestCodexEngineRenderMCPConfig/github_tool_with_user_agent to assert GITHUB_HOST is present in both TOML (env/env_vars) and the JSON MCP gateway config.
  • Regenerated WASM compile golden files to include GITHUB_HOST in the GitHub MCP server env block.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
pkg/workflow/codex_engine_test.go Adjusts test expectations for rendered MCP config to include GITHUB_HOST.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden Regenerated compiled fixture output to include GITHUB_HOST.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden Regenerated compiled fixture output to include GITHUB_HOST.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden Regenerated compiled fixture output to include GITHUB_HOST.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build/test failures on main

3 participants