fix: update tests and golden files for GITHUB_HOST in GitHub MCP server config#20956
Merged
fix: update tests and golden files for GITHUB_HOST in GitHub MCP server config#20956
Conversation
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
…MCP server config Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
dsyme
March 14, 2026 16:05
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates test expectations and regenerated WASM golden outputs to match the recently introduced GITHUB_HOST env var in the GitHub MCP server configuration, fixing CI failures caused by stale fixtures.
Changes:
- Updated
TestCodexEngineRenderMCPConfig/github_tool_with_user_agentto assertGITHUB_HOSTis present in both TOML (env/env_vars) and the JSON MCP gateway config. - Regenerated WASM compile golden files to include
GITHUB_HOSTin the GitHub MCP serverenvblock.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/codex_engine_test.go | Adjusts test expectations for rendered MCP config to include GITHUB_HOST. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden | Regenerated compiled fixture output to include GITHUB_HOST. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden | Regenerated compiled fixture output to include GITHUB_HOST. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden | Regenerated compiled fixture output to include GITHUB_HOST. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI broke after
GITHUB_HOST: "${GITHUB_SERVER_URL}"was added to the GitHub MCP server env inmcp_renderer_github.gowithout updating the corresponding tests and golden files.Changes
codex_engine_test.go: UpdatedTestCodexEngineRenderMCPConfig/github_tool_with_user_agentto expectGITHUB_HOSTin:env/env_varsfields:env = { "GITHUB_HOST" = "$GITHUB_SERVER_URL", ... }"GITHUB_HOST": "$GITHUB_SERVER_URL",beforeGITHUB_LOCKDOWN_MODEGolden files (
basic-copilot,smoke-copilot,with-imports): Regenerated viago test ./pkg/workflow -run='^TestWasmGolden_' -updateto reflectGITHUB_HOSTin compiled output.