Skip to content

Fix build-wasm: update golden files for mcpg v0.1.19#21747

Merged
pelikhan merged 3 commits intomainfrom
copilot/67694876775-fix-github-actions-workflow
Mar 19, 2026
Merged

Fix build-wasm: update golden files for mcpg v0.1.19#21747
pelikhan merged 3 commits intomainfrom
copilot/67694876775-fix-github-actions-workflow

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

TestWasmGolden_CompileFixtures was failing because DefaultMCPGatewayVersion in pkg/constants/constants.go was bumped to v0.1.19, but the golden files and a compiled lock file still referenced v0.1.18.

Changes

  • Golden test files — updated gh-aw-mcpg image tag from v0.1.18v0.1.19 in:
    • testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden
    • testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden
    • testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden
  • Lock file — same version bump in pkg/cli/workflows/example-blocked-domains.lock.yml
Original prompt

Fix the failing GitHub Actions workflow build-wasm
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 67694876775
Job URL: https://github.com/github/gh-aw/actions/runs/23281185785/job/67694876775


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

The build-wasm CI job was failing because golden test files referenced
ghcr.io/github/gh-aw-mcpg:v0.1.18, but the code (DefaultMCPGatewayVersion
in pkg/constants/constants.go) was already updated to v0.1.19.

Updated all 3 golden files and example-blocked-domains.lock.yml to match.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] [67694876775] Fix the failing GitHub Actions workflow build-wasm Fix build-wasm: update golden files for mcpg v0.1.19 Mar 19, 2026
Copilot AI requested a review from pelikhan March 19, 2026 05:55
@pelikhan pelikhan marked this pull request as ready for review March 19, 2026 05:59
Copilot AI review requested due to automatic review settings March 19, 2026 05:59
@pelikhan pelikhan merged commit 63844b8 into main Mar 19, 2026
49 checks passed
@pelikhan pelikhan deleted the copilot/67694876775-fix-github-actions-workflow branch March 19, 2026 05:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates wasm golden test fixtures and an example workflow lock file to match the bumped default MCP Gateway image version (gh-aw-mcpg:v0.1.19), resolving the TestWasmGolden_CompileFixtures failure in the build-wasm workflow.

Changes:

  • Bumped gh-aw-mcpg image tag from v0.1.18 to v0.1.19 in wasm golden fixture outputs.
  • Updated pkg/cli/workflows/example-blocked-domains.lock.yml to reference gh-aw-mcpg:v0.1.19 consistently.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden Updates golden output to use gh-aw-mcpg:v0.1.19 for predownload + gateway run command.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden Updates golden output to use gh-aw-mcpg:v0.1.19 for predownload + gateway run command.
pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden Updates golden output to use gh-aw-mcpg:v0.1.19 for predownload + gateway run command.
pkg/cli/workflows/example-blocked-domains.lock.yml Updates locked example workflow to pull/run gh-aw-mcpg:v0.1.19.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants