[log] Add debug logging to CLI and workflow package functions#22192
Merged
[log] Add debug logging to CLI and workflow package functions#22192
Conversation
Add meaningful debug logging calls to 5 files that had declared logger variables but minimal or no usage, improving troubleshooting visibility: - pkg/cli/logs_report.go: Log entry for buildToolUsageSummary, buildMissingToolsSummary, buildMissingDataSummary, and buildMCPFailuresSummary with processed run counts - pkg/workflow/tools_parser.go: Log configuration type decisions in parseBashTool, parsePlaywrightTool, and parseSerenaTool - pkg/cli/add_command.go: Log workflow counts and names in addWorkflows, addWorkflowsWithTracking, and addWorkflowWithTracking - pkg/workflow/expression_parser.go: Log BreakAtParentheses entry when actually breaking, and VisitExpressionTree nil-node path - pkg/cli/mcp_inspect_mcp.go: Log connection details in connectToMCPServer, connectStdioMCPServer, and displayServerCapabilities Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pelikhan
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add meaningful debug logging calls to 5 files that had declared logger variables but minimal or no usage, improving troubleshooting visibility for developers using
DEBUG=*mode.Files modified
pkg/cli/logs_report.go— Added entry-level logging tobuildToolUsageSummary,buildMissingToolsSummary,buildMissingDataSummary, andbuildMCPFailuresSummaryshowing the number of processed runs being aggregated.pkg/workflow/tools_parser.go— Added logging toparseBashTool(logging nil/bool/explicit-disable paths),parsePlaywrightTool(default vs configured), andparseSerenaTool(short-syntax language list vs full config).pkg/cli/add_command.go— Added logging toaddWorkflows(workflow count),addWorkflowsWithTracking(count + options), andaddWorkflowWithTracking(workflow name + content size).pkg/workflow/expression_parser.go— Added logging toBreakAtParentheseswhen actually breaking a long expression, and toVisitExpressionTreeon the nil-node path.pkg/cli/mcp_inspect_mcp.go— Added logging toconnectToMCPServer(server name + type),connectStdioMCPServer(command + arg count), anddisplayServerCapabilities(tool/resource counts + filter).Test plan
make buildpasses with no compilation errorsgo test -run TestNothing ./pkg/cli/... ./pkg/workflow/...)reportLog,toolsParserLog,addLog,expressionsLog,mcpInspectServerLog)🤖 Generated with [Claude Code]((claude.com/redacted)