Skip to content

fix(safe-outputs): add 🎭 emoji to staged mode preview in PR review handlers (USE-003) #22621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Mar 24, 2026
+10 −1
Merged

fix(safe-outputs): add 🎭 emoji to staged mode preview in PR review handlers (USE-003) #22621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b295616
Initial plan
Copilot Mar 24, 2026
0592bfa
fix(safe-outputs): add 🎭 emoji to staged mode in PR review handlers (…
Copilot Mar 24, 2026
d819ce4
fix: use isStagedMode(config) for logStagedPreviewInfo to cover globa…
Copilot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions actions/setup/js/create_pr_review_comment.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const { resolveTargetRepoConfig, resolveAndValidateRepo } = require("./repo_help
const { sanitizeContent } = require("./sanitize_content.cjs");
const { createAuthenticatedGitHubClient } = require("./handler_auth.cjs");
const { buildWorkflowRunUrl } = require("./workflow_metadata_helpers.cjs");
const { isStagedMode, logStagedPreviewInfo } = require("./safe_output_helpers.cjs");

/** @type {string} Safe output type handled by this module */
const HANDLER_TYPE = "create_pull_request_review_comment";
Expand Down Expand Up @@ -50,6 +51,9 @@ async function main(config = {}) {
if (config.staged === true) {
buffer.setStaged(true);
}
if (isStagedMode(config)) {
logStagedPreviewInfo("PR review comments will be previewed without being submitted");
}

// Track how many items we've processed for max limit
let processedCount = 0;
Expand Down
2 changes: 2 additions & 0 deletions actions/setup/js/safe_output_helpers.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

const { getErrorMessage } = require("./error_helpers.cjs");
const { matchesSimpleGlob } = require("./glob_pattern_helpers.cjs");
const { logStagedPreviewInfo } = require("./staged_preview.cjs");

/**
* Parse a comma-separated list of allowed items from environment variable
Expand Down Expand Up @@ -417,4 +418,5 @@ module.exports = {
matchesBlockedPattern,
isUsernameBlocked,
isStagedMode,
logStagedPreviewInfo,
};
5 changes: 4 additions & 1 deletion actions/setup/js/submit_pr_review.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @typedef {import('./types/handler-factory').HandlerFactoryFunction} HandlerFactoryFunction
*/

const { resolveTarget } = require("./safe_output_helpers.cjs");
const { resolveTarget, isStagedMode, logStagedPreviewInfo } = require("./safe_output_helpers.cjs");
const { resolveTargetRepoConfig, resolveAndValidateRepo } = require("./repo_helpers.cjs");
const { createAuthenticatedGitHubClient } = require("./handler_auth.cjs");
const { getErrorMessage } = require("./error_helpers.cjs");
Expand Down Expand Up @@ -50,6 +50,9 @@ async function main(config = {}) {
if (config.staged === true) {
buffer.setStaged(true);
}
if (isStagedMode(config)) {
logStagedPreviewInfo("PR review will be previewed without being submitted");
}

let processedCount = 0;

Expand Down