Skip to content

fix: extend dangerous URL scheme check to include data: protocol #22766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 24, 2026
+9 −14
Merged

fix: extend dangerous URL scheme check to include data: protocol #22766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ef9b9
Initial plan
Copilot Mar 24, 2026
d9c2ba7
fix: add data: scheme to URL protocol check in markdown security scan…
Copilot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/daily-fact.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 3 additions & 8 deletions pkg/workflow/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,15 +148,10 @@
"version": "v4.34.1",
"sha": "cb06a0a8527b2c6970741b3a0baa15231dc74a4c"
},
"github/gh-aw-actions/setup@v0": {
"github/gh-aw-actions/setup@v0.63.1": {
"repo": "github/gh-aw-actions/setup",
"version": "v0",
"sha": "50f4fc16883c6c6672d8879affa8fd15d5cc79a4"
},
"github/gh-aw-actions/setup@v0.62.5": {
"repo": "github/gh-aw-actions/setup",
"version": "v0.62.5",
"sha": "dc50be57c94373431b49d3d0927f318ac2bb5c4c"
"version": "v0.63.1",
"sha": "53e09ec0be6271e81a69f51ef93f37212c8834b0"
},
Comment on lines +151 to 155
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the github/gh-aw-actions/setup@v0 pin and only keeps @v0.63.1. In strict compilation mode, steps that reference .../setup@v0 can no longer be SHA-pinned because GetActionPinWithData requires an exact version match when StrictMode is true (the semver-compatible fallback is non-strict only). Consider keeping an explicit .../setup@v0 entry (with version: "v0") alongside the v0.63.1 entry, or update all workflows to reference @v0.63.1 so strict pinning continues to work.

This issue also appears on line 151 of the same file.

Copilot uses AI. Check for mistakes.
"github/stale-repos@v9.0.4": {
"repo": "github/stale-repos",
Expand Down
4 changes: 2 additions & 2 deletions pkg/workflow/markdown_security_scanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,9 +478,9 @@ func scanObfuscatedLinks(content string) []SecurityFinding {
})
}

// Check for javascript: or vbscript: protocols
// Check for javascript:, vbscript:, or data: protocols
lowerURL := strings.ToLower(strings.TrimSpace(linkURL))
if strings.HasPrefix(lowerURL, "javascript:") || strings.HasPrefix(lowerURL, "vbscript:") {
if strings.HasPrefix(lowerURL, "javascript:") || strings.HasPrefix(lowerURL, "vbscript:") || strings.HasPrefix(lowerURL, "data:") {
Comment on lines +481 to +483
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data: is now checked twice for markdown links: first via dataURIPattern.MatchString(linkURL) and again via the new HasPrefix(lowerURL, "data:") protocol check. For typical data:text/html;... URLs this will append two findings for the same link/line, which can create noisy/duplicated scan output. Consider consolidating into a single data-URI finding (e.g., broaden dataURIPattern to cover the intended cases and remove data: from the protocol-prefix check, or short-circuit/continue after the data-URI match so only one finding is emitted).

See below for a potential fix:

			// Check for javascript: or vbscript: protocols
			lowerURL := strings.ToLower(strings.TrimSpace(linkURL))
			if strings.HasPrefix(lowerURL, "javascript:") || strings.HasPrefix(lowerURL, "vbscript:") {

Copilot uses AI. Check for mistakes.
findings = append(findings, SecurityFinding{
Category: CategoryObfuscatedLinks,
Description: "markdown link uses dangerous protocol: " + strings.SplitN(lowerURL, ":", 2)[0],
Expand Down
Loading