Merged
Conversation
- Remove redundant null guard on parseRequiredPermissions() return value (always returns string[], never null/undefined) - Remove redundant null guard on parseAllowedBots() return value (always returns string[], never null/undefined) - Add 2 new tests: empty and unset GH_AW_ALLOWED_BOTS skip bot check (24 → 26 tests) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies check_membership.cjs by removing redundant null/undefined guards around values that are guaranteed to be arrays, and adds targeted tests to lock in the expected behavior when the bot allowlist env var is empty or unset.
Changes:
- Removed dead null checks for
requiredPermissionsandallowedBotsincheck_membership.cjs(both parsers always returnstring[]). - Added 2 tests ensuring bot-status API calls are skipped when
GH_AW_ALLOWED_BOTSis""or unset.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| actions/setup/js/check_membership.cjs | Removes redundant guards now that env parsing utilities always return arrays. |
| actions/setup/js/check_membership.test.cjs | Adds regression tests verifying no bot-check API calls when allowlist is empty/unset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleaned
check_membership.cjs— a github-script context file that handles repository membership and permission validation.Changes
check_membership.cjs— removed redundant null guards:parseRequiredPermissions()always returnsstring[](via?? []), so!requiredPermissions ||was a dead checkparseAllowedBots()always returnsstring[](via?? []), soallowedBots &&was a dead checkTest improvements
check_membership.test.cjs— 24 → 26 tests (+2):should skip bot check when GH_AW_ALLOWED_BOTS is empty stringshould skip bot check when GH_AW_ALLOWED_BOTS is not setContext
github-script✅ Validation checks
npm run format:cjs✓npm run lint:cjs✓npm run typecheck✓npm run test:js -- --no-file-parallelism✓ (26/26 passed)